[#29581] - [4.0] Remove unused use statements and alphasort
- Fixed in Code Base
- 14 Jun 2020
- Medium
- Build: 4.0-dev
- # 29581
- Diff
- Hackwar:j4imports
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
This removes unused use statements and alphasorts them everywhere. I'm relying on PHPStorm here, so I haven't tested every single file. If you want to do this yourself, simply select the project root (or the file that you want to check) and press CTRL-ALT-o. This does more than check all PHP files and I removed everything non-PHP, but unfortunately the SVG file slipped through the cracks...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_content com_fields com_finder com_installer com_languages com_menus com_tags com_users com_workflow Modules |
Using Eclipse I looked at almost all of the files bearing a tiny red x marker - usually indicating a list of use statements. I skipped some of those in vendor. I only found one list not in apparent alphabet order, in plugins/system/remember/remember.php:
use Joomla\CMS\Plugin\CMSPlugin;
use Joomla\CMS\Plugin\PluginHelper;
use Joomla\CMS\User\UserHelper;
use Joomls\CMS\Log\Log;
If you look closely that last is Joomls with an s. Is this a pass?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29581.
use Joomls\CMS\Log\Log;
that's a typo
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29581.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29581.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29581.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-14 11:20:58 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
tks
Agree. Should have been removed long ago in fact
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29581.