Joomla! Issue Tracker | Joomla! CMS #29440 - [4.0] Add unit tests for AccessiblemediaField

? ?

Fixed in Code Base
7 Jun 2020
Medium
Build: 4.0-dev
# 29440
Diff
astridx:testmedia2

Pending

Pending Hound Hound is busy sniffing around... Details

User tests: Successful: Unsuccessful:

astridx
5 Jun 2020

Pull Request for #27712 .

Summary of Changes

i added Tests

Testing Instructions

Code review and/or run the unit tests like explained here.

6fdf915 5 Jun 2020

constructor

5a89caf 5 Jun 2020

test for accessiblemediafield

astridx - open - 5 Jun 2020

astridx - change - 5 Jun 2020

Status

New

⇒

Pending

joomla-cms-bot - change - 5 Jun 2020

Category

⇒

Unit Tests

richard67 - test_item - 6 Jun 2020 - Tested successfully

richard67 - comment - 6 Jun 2020

I have tested this item ✅ successfully on 5a89caf

With this PR 9 more unit tests are executed than without this PR.

When running the unit tests with option "--debug", logging into a log file and comparing the results with and whout the PR, you can see following tests are executed in addition:

Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testIsConstructable' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testIsConstructable' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testGetWithDefaultValues' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testGetWithDefaultValues' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetAndGetShouldBeEquals' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetAndGetShouldBeEquals' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetAndGetShouldNotBeEquals' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetAndGetShouldNotBeEquals' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithEmptyValue' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithEmptyValue' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithValueThatIsValidButNotAccessible' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithValueThatIsValidButNotAccessible' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithValueThatIsValid' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithValueThatIsValid' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithValueThatIsNotValid' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithValueThatIsNotValid' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithElementIsNoField' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithElementIsNoField' ended

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29440.}

wilsonge - change - 7 Jun 2020

Status	Pending	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2020-06-07 13:16:10
Closed_By		⇒	wilsonge
Labels	Added: ? ?

wilsonge - close - 7 Jun 2020

wilsonge - merge - 7 Jun 2020

wilsonge - comment - 7 Jun 2020

Drone seems happy. Thankyou very much!

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#29440] - [4.0] Add unit tests for AccessiblemediaField

Summary of Changes

Testing Instructions

Add a Comment