Feeling Lucky
?
[#29397] - [4.0] LDAP Authentication fix
- Fixed in Code Base
- 5 Jun 2020
- Medium
- Build: 4.0-dev
- # 29397
- Diff
- travisrisner:4.0-dev-ldap-fix
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
When trying to login to a website with LDAP enabled, I was getting this error message:
Argument 2 passed to Symfony\Component\Ldap\Ldap::escape() must be of the type string, null given
Looking at the Symfony LDAP component, it appears the escape function does expect a string for that second parameter. I changed the second parameter on calls to the escape function in Symfony's LDAP component to a blank string instead of null where null was being used.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-05 10:42:10 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 5 Jun 2020
Merging this on review
I'm confident the tests aren't related to this PR as we don't currently have system tests for the LDAP Auth
@travisrisner Could you update the branch for this PR to latest changing in the 4.0-dev branch of the CMS? The system tests done by drone for postgresql are failing, and I think it could be because we had a mistake in 4.0-dev which meanwhile is solved but could have been there when you had created your branch. Let me know if you need advice. Thanks in advance.
P.S.: I don't have tested yet, but code review looks ok to me, I'm convinced this PR here is right.