? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
2 Jun 2020

This PR stops splitting nested fieldsets using the params layout from being split again into columns

Possible solution to #29388 and #29254

before

image

after

image

I have not checked to see if there are other places where this happens other than the example in the screenshot with com_tags

avatar brianteeman brianteeman - open - 2 Jun 2020
avatar brianteeman brianteeman - change - 2 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jun 2020
Category Layout
avatar Quy
Quy - comment - 2 Jun 2020

See similar PR #28790

avatar brianteeman
brianteeman - comment - 2 Jun 2020

@Quy that one still splits into columns and would still cause the problems reported elsewhere

avatar Quy
Quy - comment - 2 Jun 2020

Yes, then we run into issue #27672 with one column.

avatar Quy
Quy - comment - 2 Jun 2020

See George's comment: #28790 (comment)

avatar brianteeman
brianteeman - comment - 2 Jun 2020

Not with this pr

avatar Quy
Quy - comment - 2 Jun 2020

OK. Let me test it later and report back.

avatar Quy
Quy - comment - 3 Jun 2020

Before PR:
29398-before

After PR:
29398-after

So #27672 and George's comment #28790 (comment) are related.

avatar brianteeman
brianteeman - comment - 3 Jun 2020

Then my code is wrong. The intention was that it would only stop nested fieldsets from splitting in to columns but keep the columns on the non-nested fieldsets

avatar Quy
Quy - comment - 3 Jun 2020

Similar changes have to be done as #28790 but for one column. See Edit article > Configure Edit Screen where it is 2 columns and should be 1 for consistency.

avatar brianteeman brianteeman - change - 24 Jun 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-06-24 08:08:25
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 24 Jun 2020

Add a Comment

Login with GitHub to post a comment