? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
2 Jun 2020

Removing obsolete code from table classes in /libraries/src/Table. All bind methods can be replaced by the json-encode-fields-feature and the publish methods can all be dropped with the columnAlias feature.

avatar Hackwar Hackwar - open - 2 Jun 2020
avatar Hackwar Hackwar - change - 2 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jun 2020
Category Libraries
avatar Hackwar Hackwar - change - 2 Jun 2020
Labels Added: ?
avatar dgrammatiko
dgrammatiko - comment - 3 Jun 2020

@Hackwar for shake of B/C shouldn't you leave the public facing functions in the library [libraries/src/Table/CoreContent.php] (so it won't break things)? eg

public function bind($array, $ignore = '')
{
}
public function publish($pks, $state, $userId)
{
return true;
}
avatar Hackwar
Hackwar - comment - 3 Jun 2020

Those aren't gone. They are still in the parent Table class and are all used there. All those methods just implemented special behavior (like the publish methods) because fields were named differently. Since we can now alias a column, we don't need a special case for a table that has a column named state instead of published anymore and this can simply be removed. It is completely B/C

avatar dgrammatiko
dgrammatiko - comment - 3 Jun 2020

@Hackwar my comment was just by looking at the public part of the function. If it's not reachable or the parent will take care of it then it's fine

avatar Quy
Quy - comment - 5 Jun 2020

Remove use statements.

avatar Hackwar
Hackwar - comment - 8 Jun 2020

Remove use statements.

done

avatar bonzani bonzani - test_item - 14 Jun 2020 - Tested successfully
avatar bonzani
bonzani - comment - 14 Jun 2020

I have tested this item successfully on 7dab791


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29396.

avatar chmst chmst - test_item - 23 Jun 2020 - Tested successfully
avatar chmst
chmst - comment - 23 Jun 2020

I have tested this item successfully on 7dab791

I have tested in backend in several components with adding / changing / ordering items and found no issue.

Not tested with 3rd party components or updated installations.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29396.

avatar richard67
richard67 - comment - 23 Jun 2020

@bonzani How did you test this pull request? It doesn't provide any testing instructions.

@Hackwar Ever thought about providing testing instructions? And (inspired by past experience): Have you tested your changes yourself?

avatar bonzani
bonzani - comment - 24 Jun 2020

@richard67 I did move around items in the backend components. Since test instructions are missing, I just tried to cover code paths that where affected by this PR. But might also just have been a lucky test. Hard to say without specific instructions! But since it is analogous to the other two PR's that removed about the same code the changes looked fine.

avatar richard67
richard67 - comment - 24 Jun 2020

@bonzani Thanks for the feedback.

avatar bonzani
bonzani - comment - 24 Jun 2020

Your welcome. I try to allocate a little spare time (but I do not have much), to help with the testing so that we hopefully see version 4 released this year!

avatar SharkyKZ SharkyKZ - change - 13 Jul 2020
Status Pending Ready to Commit
avatar SharkyKZ
SharkyKZ - comment - 13 Jul 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29396.

avatar wilsonge wilsonge - change - 25 Jul 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-07-25 22:49:45
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 25 Jul 2020
avatar wilsonge wilsonge - merge - 25 Jul 2020
avatar wilsonge
wilsonge - comment - 25 Jul 2020

Thanks!

Add a Comment

Login with GitHub to post a comment