User tests: Successful: Unsuccessful:
Removing obsolete code from table classes in /libraries/src/Table. All bind methods can be replaced by the json-encode-fields-feature and the publish methods can all be dropped with the columnAlias feature.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
?
|
Those aren't gone. They are still in the parent Table class and are all used there. All those methods just implemented special behavior (like the publish methods) because fields were named differently. Since we can now alias a column, we don't need a special case for a table that has a column named state instead of published anymore and this can simply be removed. It is completely B/C
Remove use statements.
Remove use statements.
done
I have tested this item
I have tested this item
I have tested in backend in several components with adding / changing / ordering items and found no issue.
Not tested with 3rd party components or updated installations.
@richard67 I did move around items in the backend components. Since test instructions are missing, I just tried to cover code paths that where affected by this PR. But might also just have been a lucky test. Hard to say without specific instructions! But since it is analogous to the other two PR's that removed about the same code the changes looked fine.
Your welcome. I try to allocate a little spare time (but I do not have much), to help with the testing so that we hopefully see version 4 released this year!
Status | Pending | ⇒ | Ready to Commit |
RTC.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-25 22:49:45 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
@Hackwar for shake of B/C shouldn't you leave the public facing functions in the library [libraries/src/Table/CoreContent.php] (so it won't break things)? eg