NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
31 May 2020

Pull Request for Issue #26579 . (release blocker)

Summary of Changes

  • Some JS magic (not really)
  • remove the inline js from the toggle button

Testing Instructions

Create an article
Toggle to html editor and add some code, e.g.

<div style="border: 1px solid red; padding: 10px;">
    <div style="border: 1px solid blue; padding: 10px;">Some text here</div>
</div>

(Without toggling Editor) Click/tap 'Save'

Expected result

Save the correct content

Actual result

Saves the wrong content (uses the content that existed before switching to naked)

Documentation Changes Required

NO

avatar dgrammatiko dgrammatiko - open - 31 May 2020
avatar dgrammatiko dgrammatiko - change - 31 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2020
Category Administration Language & Strings JavaScript Repository NPM Change Layout Front End Plugins
avatar dgrammatiko dgrammatiko - change - 31 May 2020
Labels Added: ? NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2020
Category Administration Language & Strings JavaScript Repository NPM Change Layout Front End Plugins JavaScript Repository NPM Change Layout
avatar dgrammatiko dgrammatiko - change - 31 May 2020
Labels Removed: ?
avatar dgrammatiko dgrammatiko - change - 31 May 2020
The description was changed
avatar dgrammatiko dgrammatiko - edited - 31 May 2020
avatar richard67 richard67 - test_item - 31 May 2020 - Tested successfully
avatar richard67
richard67 - comment - 31 May 2020

I have tested this item successfully on b1f9734


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29351.

avatar dgrammatiko dgrammatiko - change - 31 May 2020
Labels Added: ?
avatar dgrammatiko
dgrammatiko - comment - 31 May 2020

An update here: the second commit is cleaning up the initialisation a bit and it's confirmed solution from the tinyMCE authors: tinymce/tinymce#5712 (comment)

avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2020
Category JavaScript Repository NPM Change Layout JavaScript Repository NPM Change Layout Front End Plugins
avatar dgrammatiko dgrammatiko - change - 1 Jun 2020
Labels Added: ?
Removed: ?
avatar richard67
richard67 - comment - 1 Jun 2020

@dgrammatiko Just am preparing for testing this. Do you plan any further changes for which I should wait?

avatar dgrammatiko
dgrammatiko - comment - 1 Jun 2020

@richard67 no more tweaks then, go ahead

avatar richard67 richard67 - test_item - 1 Jun 2020 - Tested successfully
avatar richard67
richard67 - comment - 1 Jun 2020

I have tested this item successfully on 0d502f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29351.

avatar Quy Quy - test_item - 1 Jun 2020 - Tested successfully
avatar Quy
Quy - comment - 1 Jun 2020

I have tested this item successfully on 0d502f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29351.

avatar Quy Quy - change - 1 Jun 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 1 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29351.

avatar Quy
Quy - comment - 1 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29351.

avatar wilsonge wilsonge - change - 1 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-01 22:45:13
Closed_By wilsonge
Labels Added: ?
Removed: ?
avatar wilsonge wilsonge - close - 1 Jun 2020
avatar wilsonge wilsonge - merge - 1 Jun 2020
avatar wilsonge
wilsonge - comment - 1 Jun 2020

Thanks!

Add a Comment

Login with GitHub to post a comment