NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
31 May 2020

Pull Request for Issue # .

Summary of Changes

Fixes buttons not working when clicking on icons.

Testing Instructions

node build.js --compile-js required.
Edit global configuration or template settings in frontend.
Click on the icon inside the button to submit form.

Expected result

Form submitted.

Actual result

Form not submitted. JS error appears:

TypeError: form is undefined validate.js:265:22
    isValid media/system/js/fields/validate.js:265
    submitTask media/com_config/js/config-default.js:21
    registerEvents media/com_config/js/config-default.js:36

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 31 May 2020
avatar SharkyKZ SharkyKZ - change - 31 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2020
Category JavaScript Repository NPM Change
avatar SharkyKZ SharkyKZ - change - 31 May 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 31 May 2020
avatar richard67 richard67 - test_item - 31 May 2020 - Tested successfully
avatar richard67
richard67 - comment - 31 May 2020

I have tested this item successfully on a5e20f0

Very tricky, you really have to hit the icon inside the button and not the rest of the button to get the error.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29350.

avatar Quy Quy - test_item - 31 May 2020 - Tested successfully
avatar Quy
Quy - comment - 31 May 2020

I have tested this item successfully on a5e20f0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29350.

avatar Quy Quy - change - 31 May 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 31 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29350.

avatar richard67 richard67 - change - 31 May 2020
Labels Added: ? ? NPM Resource Changed
avatar wilsonge wilsonge - change - 31 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-31 23:10:02
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 31 May 2020
avatar wilsonge wilsonge - merge - 31 May 2020
avatar wilsonge
wilsonge - comment - 31 May 2020

Thanks!

Add a Comment

Login with GitHub to post a comment