NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
26 May 2020

Pull Request for Issue #28524 .

Summary of Changes

Add missing enable/disable of the input for the HTML body to the javascript for Mail Templates admin edit, like it is already there for the input for the (text) body.

Testing Instructions

Preparation

For reproducing the issue you have to use a clean 4.0-dev staging branch or latest J4 nightly build.

For testing the patch of this Pull Request (PR) here, you have to do following 2 steps:

  1. Apply the patch e.g. with patchtester on a clean 4.0-dev staging branch or latest J4 nightly build.
  2. Run npm ci or npm run build:js.

If you don't have npm, make a new installation with the installation package build for this PR, and then test. No need to apply the patch in this case, the patch is already included. You can find the installation package here: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/29229/downloads/32398/

Execution

  1. See issue #28524 : Check if you can add an HTML body to a mail template. Check that the HTML body is not lost after saving.
  2. Try to toggle the editor.
  3. Try to insert into the HTML body some of the replacement tags shown right beside the editor.

Expected result with patch applied

You can add an HTML body for an email template, and it's not lost after saving.

You can add replacement tags to the HTML body of an email template.

You can toggle the editor.

Actual result without patch applied

You can't save an HTML body for an email template, see issue #28524 .

You can't add replacement tags to the HTML body of an email template.

You can't really toggle the editor.

Documentation Changes Required

None, except if we have some documentation telling that the above shall not work ;-)

avatar richard67 richard67 - open - 26 May 2020
avatar richard67 richard67 - change - 26 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2020
Category JavaScript Repository NPM Change
avatar richard67
richard67 - comment - 26 May 2020

Adding release blocker label as inherited by the referenced issue.

avatar richard67 richard67 - change - 26 May 2020
The description was changed
avatar richard67 richard67 - edited - 26 May 2020
avatar richard67 richard67 - change - 26 May 2020
The description was changed
avatar richard67 richard67 - edited - 26 May 2020
avatar richard67 richard67 - change - 26 May 2020
The description was changed
avatar richard67 richard67 - edited - 26 May 2020
avatar richard67 richard67 - change - 26 May 2020
The description was changed
avatar richard67 richard67 - edited - 26 May 2020
avatar richard67 richard67 - change - 26 May 2020
The description was changed
avatar richard67 richard67 - edited - 26 May 2020
avatar richard67 richard67 - change - 26 May 2020
The description was changed
avatar richard67 richard67 - edited - 26 May 2020
avatar richard67 richard67 - change - 26 May 2020
The description was changed
avatar richard67 richard67 - edited - 26 May 2020
avatar wilsonge wilsonge - change - 26 May 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-26 14:20:27
Closed_By wilsonge
Labels Added: NPM Resource Changed ? ?
avatar wilsonge wilsonge - close - 26 May 2020
avatar wilsonge wilsonge - merge - 26 May 2020
avatar wilsonge
wilsonge - comment - 26 May 2020

LGTM! Thanks!

avatar richard67
richard67 - comment - 26 May 2020

?

Add a Comment

Login with GitHub to post a comment