? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
26 May 2020

Summary of Changes

Currently, Joomla\CMS\Extension\ExtensionHelper::getExtensionRecord() uses extension "name" to retrieve extension record. But the name is not standardized, not unique and can not be relied on.

This changes the method to be based on element, extension type and, optionally, client ID and folder.

Testing Instructions

Postinstall module and other code using the method should work like before.

Documentation Changes Required

Maybe. Existing uses Joomla\CMS\Extension\ExtensionHelper::getExtensionRecord() need to be updated to account for changes in function signature.

avatar SharkyKZ SharkyKZ - open - 26 May 2020
avatar SharkyKZ SharkyKZ - change - 26 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2020
Category Administration com_admin com_installer com_joomlaupdate com_postinstall Modules Libraries Front End Plugins
avatar richard67 richard67 - test_item - 27 May 2020 - Tested successfully
avatar richard67
richard67 - comment - 27 May 2020

I have tested this item successfully on 05f4534


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29230.

avatar bonzani bonzani - test_item - 28 May 2020 - Tested successfully
avatar bonzani
bonzani - comment - 28 May 2020

I have tested this item successfully on 05f4534


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29230.

avatar richard67 richard67 - change - 28 May 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 28 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29230.

avatar richard67 richard67 - change - 28 May 2020
Labels Added: ? ?
avatar HLeithner HLeithner - change - 28 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-28 08:06:38
Closed_By HLeithner
Labels
avatar HLeithner HLeithner - close - 28 May 2020
avatar HLeithner HLeithner - merge - 28 May 2020
avatar HLeithner
HLeithner - comment - 28 May 2020

Thanks

Add a Comment

Login with GitHub to post a comment