? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
26 May 2020

Summary of Changes

Currently Atum params are hardcoded in com_users form. Unless we expect every other template to follow the same settings, this is totally wrong.

This moves those settings to a separate plugin.

Testing Instructions

Edit your profile in backend, change some Atum settings.
Check that they're still respected.

Expected result

Works like before.

Documentation Changes Required

IDK

TODO

  • SQL files
avatar SharkyKZ SharkyKZ - open - 26 May 2020
avatar SharkyKZ SharkyKZ - change - 26 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2020
Category Administration com_users Language & Strings Templates (admin) Front End Plugins
avatar SharkyKZ SharkyKZ - change - 26 May 2020
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 26 May 2020

Unless we expect every other template to follow the same settings, this is totally wrong.

Yes I would like the two or three other possible admin templates to follow the same settings. My 2c

avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2020
Category Administration com_users Language & Strings Templates (admin) Front End Plugins SQL Administration com_admin Postgresql com_users Language & Strings Templates (admin) Installation Front End Plugins
avatar SharkyKZ SharkyKZ - change - 26 May 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 26 May 2020
45d6187 26 May 2020 avatar SharkyKZ Typo
avatar mbabker
mbabker - comment - 26 May 2020

Unless we expect every other template to follow the same settings, this is totally wrong.

Yes I would like the two or three other possible admin templates to follow the same settings. My 2c

Then they need to be advertised as system settings. If they are template related settings for a specific template, then core should be following the same practices that the ecosystem must follow, and the ecosystem doesn't get to stuff their settings directly into a core component.

avatar dgrammatiko
dgrammatiko - comment - 26 May 2020

Then they need to be advertised as system settings

That! Also rename it to Accessibility options and name them carefully

PS. @C-Lodder already mentioned it elsewhere that these settings ARE OS wide and thus there is no need to pamper the users with such plugins (the js thingy that renders the setting this plugin is moving around). Also it's a very good idea to ask some people with disabilities if such things are helpful to them (the answer is no because they use the browsers css override or other higher level solutions. In sort Joomla is solving a non existing problem, not the first instance...)

avatar Quy
Quy - comment - 26 May 2020

Remove Accessibility Settings from User Menu dropdown when plugin is disabled.

avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2020
Category Administration com_users Language & Strings Templates (admin) Front End Plugins SQL com_admin Postgresql Installation SQL Administration com_admin Postgresql com_users Language & Strings Modules Templates (admin) Installation Front End Plugins
avatar HLeithner
HLeithner - comment - 26 May 2020

I see no reason to move a11y settings for the template out of the user options into a plugin, basically every template should use them (at least in Europe).

avatar brianteeman
brianteeman - comment - 26 May 2020

@HLeithner actually they could use the plugin instead

avatar dgrammatiko
dgrammatiko - comment - 28 May 2020

In my previous comment I've mentioned that disabled people are using higher level solutions (eg Browser plugins). Here is the proof, dyslexic people override the fonts: https://speakerdeck.com/ninjanails/death-to-icon-fonts

Don't try to solve non existing problems because someone assumes. COVID19 teach us something: read and the data and act upon them, Joomla didn't even collected any data to make such wild assumptions...

PS if you want to make Joomla truly ACCESSIBLE then DROP the Font Awesome ICON and use their svgs. You're already inaccessible for dyslexic people that will override the fonts.
In sort solve real problems not unicorn ones...

avatar brianteeman
brianteeman - comment - 28 May 2020

Sorry but that is not 100% correct - I was under the same misapprehension myself until relatively recently. People with permanent disabilities will of course try to implement higher level solutions but not all disabilities are permanent.

avatar dgrammatiko
dgrammatiko - comment - 28 May 2020

@brianteeman all I'm saying is Joomla has bigger fish to fry to be accessible (eg the icon font!!). The widget is questionable. AFAIK gov.uk is totally accessible without any fancy widget

avatar C-Lodder
C-Lodder - comment - 28 May 2020

The below refers to the colour settings only:

Permanent or not, if you have a disability, you don't go to the settings for each individual site you use and change to greyscale, high contrast, etc.
You use software or change at OS level (normally the latter)
Even some modern monitors have these types of settings.

Windows 10, MacOS, Android and iOS all have colour filters:

  • Dark mode
  • Greyscale
  • High contrast
  • Protanopia
  • Deuteranopia
  • Tritanopia

By all means, keep whem if you want, but if you're going to do it, do it properly and support the 4 other critical ones.

avatar brianteeman
brianteeman - comment - 28 May 2020

I am not commenting further on this as you have misunderstood the objective of these settings.

avatar C-Lodder
C-Lodder - comment - 28 May 2020

Enlighten me on the objective of them then...

avatar Quy Quy - test_item - 13 Jun 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 13 Jun 2020

Please add to the list of core extensions

avatar joomla-cms-bot joomla-cms-bot - change - 13 Jun 2020
Category Administration com_users Language & Strings Templates (admin) Front End Plugins SQL com_admin Postgresql Installation Modules SQL Administration com_admin Postgresql com_users Language & Strings Modules Templates (admin) Installation Libraries Front End Plugins
avatar Quy
Quy - comment - 16 Jun 2020

Should these settings be displayed/editable on the frontend in edit profile since they are only applicable on the backend?

avatar SharkyKZ
SharkyKZ - comment - 17 Jun 2020

Maybe. Users can select backend template and language in frontend.

avatar Quy
Quy - comment - 7 Jul 2020

Please fix conflicts.

avatar Quy Quy - test_item - 8 Jul 2020 - Tested successfully
avatar Quy
Quy - comment - 8 Jul 2020

Please fix display value of 1.

29226

avatar Fedik
Fedik - comment - 9 Jul 2020

Just an idea:
Alternatively to use the plugin, we could extend templateDetails.xml markup to have something like <userParams> tag with fieldsets of User specific settings, and then User model will load it to an user Params form. This will work across all templates without extra plugin.

avatar Quy Quy - test_item - 9 Jul 2020 - Tested successfully
avatar Quy
Quy - comment - 9 Jul 2020

I have tested this item successfully on 965a652


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29226.

avatar twister65 twister65 - test_item - 12 Jul 2020 - Tested successfully
avatar twister65
twister65 - comment - 12 Jul 2020

I have tested this item successfully on 965a652


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29226.

avatar Quy Quy - change - 12 Jul 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Jul 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29226.

avatar brianteeman
brianteeman - comment - 12 Jul 2020

Want to go on record saying that for me the renaming of this plugin (removing any connection to accessibility) is wrong.
Removing the resulting accessibility option link from the user profile is wrong (that was in the very first design of j4)

As it is right now it makes no sense. The description is that this is for per user settings of the atum template so I would therefore expect to see the same options in the atum template itself for default settings and vice versa.

This is just wrong.

avatar SharkyKZ
SharkyKZ - comment - 14 Jul 2020

Want to go on record saying that for me the renaming of this plugin (removing any connection to accessibility) is wrong.

Language strings can be changed.

Removing the resulting accessibility option link from the user profile is wrong (that was in the very first design of j4)

This can be added in a layout override for Atum.

The description is that this is for per user settings of the atum template so I would therefore expect to see the same options in the atum template itself

These can be added. Monochrome option is already present in template params.

avatar SharkyKZ
SharkyKZ - comment - 14 Jul 2020

@Fedik make a PR if you want.

avatar brianteeman
brianteeman - comment - 14 Jul 2020

If you have to say "these can be added" then this can not be RTC. Don't just remove functionality and expect someone else to put it back.

avatar Fedik
Fedik - comment - 14 Jul 2020

I think we need to have a common decision on this topic before doing changes here, instead of when everyone doing something own.

I found that my idea also not much good, because then we need to store the params for every template style,
eg $userParams[template][blablaTemplate][styleId] = [.. user params for the template style...]

For now, I think, I would keep it as it is now (in User params), there no big reason to rush it while the beta state. We can back to the topic in a future, in one of 4.x

avatar SharkyKZ SharkyKZ - change - 14 Jul 2020
Labels Added: ?
avatar SharkyKZ SharkyKZ - change - 14 Jul 2020
Status Ready to Commit Pending
avatar SharkyKZ
SharkyKZ - comment - 14 Jul 2020

PR updated.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29226.

avatar SharkyKZ SharkyKZ - change - 14 Jul 2020
Labels Removed: ?
avatar brianteeman
brianteeman - comment - 14 Jul 2020
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2020
Category Administration com_users Language & Strings Templates (admin) Front End Plugins SQL com_admin Postgresql Installation Modules Libraries Unit Tests Repository Administration com_admin SQL
avatar SharkyKZ SharkyKZ - change - 21 Sep 2020
Labels Added: ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2020
Category Administration SQL com_admin Unit Tests Repository SQL Administration com_admin Postgresql com_users Language & Strings Modules Templates (admin) Installation Libraries Front End Plugins
avatar SharkyKZ SharkyKZ - change - 21 Sep 2020
Labels Added: ?
Removed: ?
avatar HLeithner
HLeithner - comment - 11 Jan 2021

since we #31884 is merged we don't need this pr any longer thanks for your time creating this anyway!

avatar HLeithner HLeithner - change - 11 Jan 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-01-11 14:05:40
Closed_By HLeithner
avatar HLeithner HLeithner - close - 11 Jan 2021
avatar SharkyKZ
SharkyKZ - comment - 11 Jan 2021

#31884 is not related to this.

Add a Comment

Login with GitHub to post a comment