Feeling Lucky
?
[#29225] - [4.0] Remove role=document from the modal dialog
- Fixed in Code Base
- 26 May 2020
- Medium
- Build: 4.0-dev
- # 29225
- Diff
- C-Lodder:patch-1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
role="document" is only needed when there is a parent role="application". Seeing as Joomla doesn't do this, it can be removed.
As of Bootstrap 4.2, it automatically adds aria-modal when the modal is opened,
Testing Instructions
Code review
Evidence
https://w3c.github.io/aria-practices/examples/dialog-modal/dialog.html
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Document_Role
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
Quy
- comment
- 26 May 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29225.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 26 May 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29225.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-26 22:00:00 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 26 May 2020
Thanks!
I have tested this item✅ successfully on e2b787e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29225.