[#29227] - [4.0] [plg_system_webauthn] Lowercase plugin name
- Fixed in Code Base
- 26 May 2020
- Medium
- Build: 4.0-dev
- # 29227
- Diff
- SharkyKZ:j4/db/lowercase-plugin-name
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Changes plugin name to be lowercase like in all other plugins.
Testing Instructions
Code review.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Isn't it wrong in all others? Normally our language strings are all uppercase iirc? But no problem with this just a question.
@HLeithner This is also stored in #__extensions table and in some places we still use extension name for running queries. Having casing discrepancy would break on PostgreSQL.
Although this specific case probably doesn't cause issues, it's just a matter of consistency.
In fact it is epiphenomenic as we use strtoupper when in lower case.
Edit: when I wrote the above, I was not aware about possible issues in PostgresSQL
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29227.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-26 10:42:28 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on 5b26c7d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29227.