NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
17 May 2020

Pull Request for Issue #29120

Summary of Changes

Use conditional for the $content variable

Testing Instructions

Make sure that the Preview Module Positions is set to enabled
Click on the eye to open the preview if in template style or Preview Toolbar in templates manager

Before patch

js error. See #29120

After patch

No more error

avatar infograf768 infograf768 - open - 17 May 2020
avatar infograf768 infograf768 - change - 17 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 May 2020
Category JavaScript Repository NPM Change
avatar brianteeman brianteeman - test_item - 17 May 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 17 May 2020

I have tested this item successfully on 673f18a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29124.

avatar richard67 richard67 - test_item - 17 May 2020 - Tested successfully
avatar richard67
richard67 - comment - 17 May 2020

I have tested this item successfully on 673f18a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29124.

avatar richard67 richard67 - change - 17 May 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 17 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29124.

avatar richard67 richard67 - change - 17 May 2020
Labels Added: ? ? NPM Resource Changed
avatar wilsonge wilsonge - change - 17 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-17 23:01:04
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 17 May 2020
avatar wilsonge wilsonge - merge - 17 May 2020
avatar wilsonge
wilsonge - comment - 17 May 2020

Thanks!

Add a Comment

Login with GitHub to post a comment