[#29122] - [4.0] Change width to class
- Fixed in Code Base
- 20 May 2020
- Medium
- Build: 4.0-dev
- # 29122
- Diff
- brianteeman:sat
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Continuation of the work @Quy did to replace style="width:xx%"
This time replaces width="xx%"
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules Installation |
@brianteeman @Quy It seems for the installation, the "w-" classes are not known. E.g. in file installation/tmpl/remove/default.php I get a bigger width when using the unmodified core file than when using the file from this PR, and when using the file from this PR and inspecting the markup and css in browser tools, I see nowhere the width of n% applied.
Update: The rest works fine, I can see the width applied in broswer inspection tool. Only for the installation it is not the case.
So you can chose what is better: Keep the old width attribute in the installation, or add the "w-" classes to file installation/template/scss/template.scss.
It displays fine without w-. Let's remove them.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29122.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29122.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29122.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending. @brianteeman Could you fix PHPCS? See the log here https://ci.joomla.org/joomla/joomla-cms/32237/1/9.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29122.
@richard67 that code is nothing to do with this PR
@richard67 they are fixed in #29163
Merging here thanks @brianteeman
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-20 11:53:08 |
| Closed_By | ⇒ | zero-24 |
Thanks
I have tested this item✅ successfully on 73be074
Thank you! I forgot about the width attribute.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29122.