[#29041] - [4.0] Use for password strength indicator
- Fixed in Code Base
- 23 May 2020
- Medium
- Build: 4.0-dev
- # 29041
- Diff
- C-Lodder:password-field
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26190
Replaces: #26430
Summary of Changes
This changes the element for the password strength indicator from <div class="progress"> to native <meter>, which is the proper semantical element for this scenario.
The JS is now ES6
Caveats
This will NOT work in IE11 or Android webview
Notes
This PR does NOT change the algorithm of the password strength. Please do not raise any issues saying you can type in an insecure password.
This PR uses the browsers native styling for the element, with the exception of setting the width to 100%. Please do not start discussing the styling here. You can raise a separate issue for that.
Testing Instructions
- Run
node build.js --compile-jsandnode build.js --compile-cssfrom your terminal. - Go to
administrator/index.php?option=com_usersand a user - Start typing in a password
Result
The meter element indicates the strength of the password
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
?
|
||||||
Iām not merging new custom elements until the existing ones stabilise which is why this has sat there
I have tested this item
Definite improvement - thanks
Also checked to make sure it works correctly when prefers-reduced-motion is set - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29041.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29041.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29041.
Merging thanks!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-23 22:28:43 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
@C-Lodder I wish you could resurrect #23215 here as there are patched much more things (eg the input is decoupled from Font Awesome, etc)