[#29040] - [4.0] Remove missing argument handling
- Fixed in Code Base
- 24 May 2020
- Medium
- Build: 4.0-dev
- # 29040
- Diff
- SharkyKZ:j4/php71
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Removes missing argument handling in Joomla\CMS\Language\Text methods. Since PHP 7.1 calling functions with missing arguments throws ArgumentCountError. So this code is never executed anymore.
Testing Instructions
Code review or test that the methods still work.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Those are still used, I think. To pass variables and additional options.
I have tested this item
Code Review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29040.
Those are still used, I think. To pass variables and additional options.
I haven't checked. If those are indeed used, then they need to be added to the function call as proper (optional) arguments. That stuff looks just hacky as it is
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29040.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29040.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-24 23:44:11 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
This is good enough as a first pass. Thankyou!
I'd argue one could remove a lot more code. All that is related to $args and $count should be removed and $string and $n be used in all places.