[#29007] - [4.0] Session Manager for destroying sessions
- Fixed in Code Base
- 29 Mar 2021
- Urgent
- Build: 4.0-dev
- # 29007
- Diff
- SharkyKZ:j4/session-thing
- Success Hound Smells good to me. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success Download Prebuilt packages are available for download. Details
- Failure continuous-integration/drone/pr Build is failing Details
- Failure JTracker/HumanTestResults Human Test Results: 0 Successful 2 Failed. Details
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins Unit Tests |
| Labels |
Added:
?
?
?
|
||
jwaisner
- | Priority | Medium | ⇒ | Urgent |
I have tested this item
I have open sessions for a registered users both in firefox and chrome
I have tried to obtain the expected result:
- Logging a user out with the icon in the "Logged-in Users" module logs a user out regardless of session handler
This happened to me befor applying the patch
- Removing a user account with a privacy request does not trigger a fatal error
The first worked fine before applying the patch
I could not test the second because of an issue I reported at
#30304
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29007.
The issue was my mistake, so I closed it #30304 (comment)
Following on my previous test, in my case "Removing a user account with a privacy request" did not trigger a fatal error
I wonder if some other patch has solved the issue. That would mean this patch is not needed anymore.
| Labels |
Added:
Conflicting Files
|
||
| Labels |
Added:
?
Removed: Conflicting Files |
||
I have tested this item
There is one problem we can fix in another PR, if you set session manager to file and click on "Log Out" in the backend, the button is still there. The user is logged out and we you refresh the frontend to user is also gone in the backend. The reason is that the session is still in the database session table. I am looking into this just need to find out where is the best place to clean the database table.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29007.
I have tested this item
Give it a successful test so that we can move forward with #32863 .
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29007.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29007.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-29 08:53:58 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
?
Removed: ? ? |
||
Thank you!
I have tested this item? unsuccessfully on bd28bc4
I have followed this steps:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29007.