[#29006] - [4.0] com_messages: fix user settings and move these params to a view
- Fixed in Code Base
- 12 May 2020
- Medium
- Build: 4.0-dev
- # 29006
- Diff
- infograf768:4.0_messages_user_settings
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28958
Summary of Changes
As title says.
The pop up is here changed to a view and the controller is corrected.
Testing Instructions
Load Private Messages Manager.
Click on My Settings button.
For example switch Lock Inbox to Yes.
Save.
Click again on the button.
Before patch
After patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_messages |
Maybe add <div class="card"> and <div class="card-body"> to the form to separate it from the background pattern.
\administrator\components\com_messages\tmpl\config\default.php
| Labels |
Added:
?
|
||
I have tested this item
lgtm
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29006.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29006.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29006.
I have tested this item
I also confirm the PR. It's a result of flag bug.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29006.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-12 08:41:07 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 9d9e846
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29006.