? ? Pending

User tests: Successful: Unsuccessful:

avatar f00x
f00x
9 May 2020

encountered while using search component Search component

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar f00x f00x - open - 9 May 2020
avatar f00x f00x - change - 9 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2020
Category External Library Libraries Composer Change
avatar SharkyKZ
SharkyKZ - comment - 9 May 2020

Thank you for the PR. But changes to files in libraries/vendor/joomla/string directory should be made against upstream https://github.com/joomla-framework/string repository.

avatar SharkyKZ
SharkyKZ - comment - 9 May 2020

Also doesn't look like correct fix. First, mb_strlen() should not be used (use strlen() method from that same class). Secondly, native strpos() shows the same warning https://3v4l.org/QGdRO.

avatar Quy
Quy - comment - 14 May 2020

Please report upstream.

avatar Quy Quy - change - 14 May 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-05-14 19:02:37
Closed_By Quy
Labels Added: ? ?
avatar Quy Quy - close - 14 May 2020
avatar f00x
f00x - comment - 28 Aug 2020

SharkyKZ . Ok Maybe the place was not chosen well .... then where do you need to make this change?
having trace

Time Memory Function Location

1 0.0003 411640 {main}( ) ...\index.php:0
2 0.1080 4669568 Joomla\CMS\Application\SiteApplication->execute( ) ...\index.php:49
3 0.1080 4669568 Joomla\CMS\Application\SiteApplication->doExecute( ) ...\CMSApplication.php:196
4 0.2241 8206320 Joomla\CMS\Application\SiteApplication->dispatch( $component = ??? ) ...\SiteApplication.php:233
5 0.2353 8441224 Joomla\CMS\Component\ComponentHelper::renderComponent( $option = 'com_search', $params = ??? ) ...\SiteApplication.php:194
6 0.2374 8447904 Joomla\CMS\Component\ComponentHelper::executeComponent( $path = 'C:\f00x\projects\golden.local/components/com_search/search.php' ) ...\ComponentHelper.php:377
7 0.2376 8466104 require_once( 'C:\f00x\projects\golden.local\components\com_search\search.php' ) ...\ComponentHelper.php:402
8 0.2412 8583416 SearchController->execute( $task = NULL ) ...\search.php:13
9 0.2412 8583416 SearchController->display( $cachable = ???, $urlparams = ??? ) ...\BaseController.php:710
10 0.2412 8583416 SearchController->display( $cachable = FALSE, $urlparams = FALSE ) ...\controller.php:34
11 0.2540 9053224 SearchViewSearch->display( $tpl = ??? ) ...\BaseController.php:672
12 0.3361 9972280 SearchViewSearch->highLight( $string = 'Первая новость ', $needle = 'первая', $searchWords = array (0 => 'первая') ) ...\view.html.php:153
13 0.3361 9972280 SearchHelper::prepareSearchContent( $text = 'Первая новость ', $searchword = 'первая' ) ...\view.html.php:219
14 0.3363 9972336 SearchHelper::_smartSubstr( $text = 'Первая новость ', $searchword = 'первая' ) ...\search.php:199
15 0.3364 9972376 Joomla\String\StringHelper::strpos( $str = 'Первая новость ', $search = ' ', $offset = 200 ) ...\search.php:293
16 0.3364 9972376 utf8_strpos( $str = 'Первая новость ', $search = ' ', $offset = 200 ) ...\StringHelper.php:183
17 0.3364 9972376 mb_strpos ( 'Первая новость ', ' ', 200 ) ...\core.php:43


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29008.

avatar f00x
f00x - comment - 28 Aug 2020

Проблема по сей день не решена (3.9.21)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29008.

avatar f00x
f00x - comment - 28 Aug 2020

Проблема по сей день не решена (3.9.21)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29008.

avatar f00x
f00x - comment - 28 Aug 2020

The problem has not been resolved to this day (3.9.21)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29008.

avatar SharkyKZ
SharkyKZ - comment - 28 Aug 2020

@f00x Can you check if #30350 fixes the issue?

avatar f00x
f00x - comment - 28 Aug 2020

Not fixed (line 293)

...\search.php*:*293
And the changes there concern the line 313

пт, 28 авг. 2020 г. в 19:15, SharkyKZ notifications@github.com:

@f00x https://github.com/f00x Can you check if #30350
#30350 fixes the issue?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#29008 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AENGZSNJDQRGZ7RY4JCV7MDSC6GUNANCNFSM4M4YKCJQ
.

--
С уважением Лисин Евгений Михайлович

avatar f00x
f00x - comment - 28 Aug 2020

@SharkyKZ
if ( $pos + $length < $textlen &&($wordpos = @StringHelper::strpos($ltext, ' ', $pos + $length)) !== false) work .
this is normal?

Add a Comment

Login with GitHub to post a comment