I have tested this item ✅ successfully on 0bfe005

With and without patch I can JED without any problem after the load. the URLs to the components open

@C-Lodder Even if it's clear to you and me, but could you next time add a hint in testing instruction if npm has to be used? We still need npm if js or scss is changed as long as Patchtester 4 with CI server doesn't work reliably. And we have many new testers since the "Bugs and Fun at Home" events. For those such a hint could be a help.

@adj9 Have you also tested if the Joomla loading logo is shown as described in the testing instructions when the patch for this Pull Request (PR) is applied? And have you run npm after having applied the patch, so the changed javascript was applied?

No need for a hint. Github does that for you.

@brianteeman I know. But I am not really sure if new testers know that, too.

@richard67 well they should be reading the github post etc in order to test ;)

@richard67 ah yes sorry, I keep forgetting.

I have tested this item ✅ successfully on 0bfe005

Can you also fix the modal.

When selecting plugin - install - the modal is on the bottom of the page.

When i click on install again, the installer isn't loaded. Only on "install from url" i see the package url

@810 Is that issue introduced by this PR?

No, same issue as on core.

When selecting plugin - install - the modal is on the bottom of the page.

Confirmed. The Install From Web seems to have some issues which are not fixed by this PR. Seems it needs more love.

@810 Do you get an error in browser console when trying to install with the button at the bottom?

Uncaught TypeError: Joomla.submitbutton5 is not a function
    at HTMLInputElement.onclick (index.php?option=com_installer&view=install:349)

@810 in which case can you please raise a separate issue?

@C-Lodder In the Install From Web is a green "Install" button at the top area. If you use that button, 2 new buttons are shown at the very bottom, a blue "Install" and a grey "Cancel". If you click the blue "Install" you get that error.

@C-Lodder Furthermore, as @810 pointed out, and I can confirm that, it seems that these 2 buttons should belong to a modal, but it is not a modal, it is integrated in the page.

Has all nothing to do with this PR. This PR doesn't change anything to worse. But maybe you can fix that with another PR?

I've just found an old meta-issue: #19429 . @C-Lodder you were also involved in it, but it is a bit old.

I'll start lookng into it now

@richard67 The logo loads it correctly. I realized now that the green taste of installazine does not work properly, on click it does nothing (Akeeba page e.g.) with & without PR.

Sorry, I gave a hasty confirmation.

@adj9 Problem with install button and others are known, we have an issue for that: #19429 . So this PR here is ok. Thanks for testing.

RTC

Tks.