[#28982] - [4.0] Multilingual: modifying lang badges to fit languages with different country codes
- Fixed in Code Base
- 8 May 2020
- Medium
- Build: 4.0-dev
- # 28982
- Diff
- infograf768:4.0_languages_badges
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
When one is using various languages with different country codes (and also when a specific language is not using the language icon), differentiating them in admin may be hard.
For example:
de-DE, de-AT, de-CH
en-GB, en-US, en-AU
fr-FR, fr-CA
etc.
The badge produced are using the language sef (URL language code) as defined in the content language but it is confusing if that sef is not simple.
I propose here to use the full language code instead as it is clearer.
It also normalises the language all over admin (See below the Administrator menu MENUS for menus containing homes)
These show in various managers (associations column, home menu item, com_associations, ...)
I am conscious that this will use more space when many languages but I think it is worth it.
Testing Instructions
Create a multilingual site and display the various managers
Before patch
After patch
Here the German de-DE content language has no image/flag
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_categories com_contact com_content com_menus com_newsfeeds com_templates |
Mail templates still show the 2 letter code if for a content language the flag is set to "None".
@infograf768 In mail templates the following 2 lines need this change, too:
If you would add a css class to the html only for the language badges, you could give them all same width with some (s)css. Since the language codes aren't translated, we could just make sure that a "ww-WW" fits into it (W because widest character in most common fonts).
@richard67
we also have lang tags of type xxx-XX
therefore better let the width auto imho.
will look at mail templates tomorrow.
@infograf768 Then I would make them all big enough for "www-WW". The auto width really looks bad. But that's just my opinion, I would not block this PR because of it.
If you want I can do the mail template changes for you. I've tested them here. Shall I? And if so, shall I make PR to your branch, or shall I commit directly to your branch? If you don't want me to do it: No problem, we can wait until tomorrow, no hurry. Just wanted to offer help if you are off desktop right now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28982.
| Labels |
Added:
?
|
||
@richard67
com_mails done
Concerning the badge width I stand with the auto. This PR is already increasing the size of these badges. Giving them an important fixed width would be counterproductive and not add to legibility imho.
Maybe the badges can be aligned differently so they look better together with different width? Anyway, not to be done by this PR, should be done separately, if something can be done.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28982.
@brianteeman
Please test again.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28982.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks for testing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28982.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-08 22:34:50 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
The "After Patch" screenshot would look better if all the badges for the languages would have the same width.