My test did not produce the same screenshots as you. The sidebar on the login and admin screens are no longer full height

@brianteeman that's strange because I did not change anything about the sidebar heights at all. Is the issue gone when you revert the patch?

Edit: just tested with patchtester without issues. Maybe revert other patches, clear caches and try again? Thank you!

Changed Border Color and box shadows of inputs to a neutral color (not blue-ish) to fit to custom schemes

I am not a fan of this change. They exist because we have no outline and serve as the focus indicator which is fairly universally a blue.

For example here on github

.form-control.focus, .form-control:focus, .form-select.focus, .form-select:focus {
    border-color: #2188ff;
    outline: none;
    box-shadow: inset 0 1px 2px rgba(27,31,35,.075), 0 0 0 0.2em rgba(3,102,214,.3);
}

@brianteeman I only desaturated the box shadow it was very light before - In terms of accessibility it's only slighty recognizeable that it changed - it makes the scheme more harmonic as before.

I did not change the focus border btw, if thats your concern, only the light shadow.

I have tested this item 🔴 unsuccessfully on f0120ab

the patch not produce the same screenshots as you

@faustonenci I used my own colors - your screenshots should not match to mine but have better results like in the posted issue: #28215 -

For the muted text color of the joomla Version: did you clear your browser cache ?
The right marked colors work as expected, they use your "special color" setting - I don't know whats the reason that they use the special color to be honest but I can work on that in another PR (Fixing it now)

the sidebar was an unrelated issue

I used random colors, and after cleaning the browser chache the only problem remains in the joomla version logo

@faustonenci can you retest now ?
Please revert the patch, fetch new, apply again and clear the browser cache

I restored all the site and the fatches, I applied the patch again, I only see a problem with the joomla version logo which unlike the other logos uses this style class
.text-muted {
color: # 6c757d! important;
}

I restored all the site and the fatches, I applied the patch again, I only see a problem with the joomla version logo which unlike the other logos uses this style class
.text-muted {
color: # 6c757d! important;
}
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28788.

Yes but I actually overwrote it in header, thats why I thought it's a cache issue :-( Anyone else has the same issue?

See:

I done a PR in your branch: coolcat-creations@e3df4f0

@Razzo1987 but you removed text-muted, I think it should be muted when the header is disabled?

@coolcat-creations Bootsrap 4 text-muted color is "var(--atum-text-light) !important"
If think it is correct because .text-muted is grey.
If you want to have the icon color the same color as the other icons you must remove it or add a more "important" definition of .text-muted in the topbar

@Razzo1987 yes I added the definition for header right from the start - it's in the _header.scss file. You don't see the changes either?

I'm not understanding the problem compared to the screen:
#28788 (comment)
I have the same color set and the same result with the code you described.

But the result is different from the request:
https://user-images.githubusercontent.com/2539440/75856202-260cd500-5df4-11ea-9f15-3a7c48398b84.png

What is the desired result?
Gray or white icon fot joomla version?

@Razzo1987 - I have an idea, can you change light text value in your settings to #ffffff and see if it works then? if yes I know what to check again.

because you see I defined the muted-text in the top bar:

Also:

Not muted: #fff instead var(--atum-text-light)
I think:

.header .header-item .header-item-content > :first-child  {
color: var(--atum-text-light) !important;
}
.header .header-item .header-item-content .text-muted {
color: var(--atum-text-light) !important;
opacity: .6;
}

instead $white try to insert var(--atum-text-light) !important

@Razzo1987 - I have an idea, can you change light text value in your settings to #ffffff and see if it works then? if yes I know what to check again.

Yes is good,
but in this way the icons can't change the color, so if you use a a dark color for Light Text:

Now I understand where all the confusion comes from- the other buttons stay white while they should change to the var(--atum-text-light) - or second possibility the Joomla Logo should be white - I think you are right, it should be all set to white in the header then like the other elements. Sorry I misunderstood the issues :-)

@Razzo1987 and @faustonenci you can retest now if you want :-)

See https://github.com/joomla/joomla-cms/pull/28788/files/8b66259a66106dafd2654a801a1176b14d094819..fa6f6e854999cab3cd0f7701d15a32f1467980a6#diff-fab202d130ff6570c9e945edeed1ffe6

Thank you @Razzo1987 and @faustonenci now it should be finally fine :-)

I have tested this item ✅ successfully on 5c207ec

good

@coolcat-creations :hover :( (see image 3)

Also.... What do you think about:

edit: the 2 blank square in Link color and Special color is an error of my test code.
The only change I propose is on the gradient form-control of the light and dark color

@Razzo1987
The hover color is the link color, I think that's "ok" - or we need to open a seperate issue and discuss the hover-color there.

Thank you for your idea about the colorslider - I honestly consider to remove the hue slider for the dark color at all and want to open a RFC issue for it - the hue slider was formaly there to satisfy the needs for the former dark sidebar and different color shades there. now we actually don't need this anymore. I don't know... Anyway this would be a separate issue too. Please let's go forward with this in small steps :-)

This PR does not make everything perfect but moves it forward at least.

sorry for delay test ✅

I have tested this item ✅ successfully on d5825c8

OK: It works as described

Last change was CS... @richard67 can I ask for RTC? :-)

@coolcat-creations Has the discussion with @C-Lodder been resolved?

@richard67 Regarding the Logo: No but thats a completely new PR / Issue to work on which I will do as next. We need to clean up and rename the used .svg Logos. They are not named properly, they are not used properly and the custom logos are not described good enough so that a user can change it in the way he/she wants. I would open the Issue directly afterwards.

Edit: Done: #28826

Last change was just CS. I've set back the test restults.
RTC

Please fix conflicts.

Thankyou for working on this @coolcat-creations ! Much appreciated!

Was the change described in issue #28906 intended?