? ? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
25 Apr 2020

Draft as basis for a discussion because of #28680 (comment) and #28755 (comment) .
(alternative for #28755 and #28680).
Also see:#28673

Summary of Changes

I implemented an idea of how we can use an Icon Font instead of SVGs

Testing Instructions

At the moment this is a RFC.

Basically I prefer SVGs. But I think that the maintenance in an open source project with an icon font is easier.

d3c5959 25 Apr 2020 avatar astridx wip
53e8f5e 25 Apr 2020 avatar astridx wip
541cad8 25 Apr 2020 avatar astridx wip
c3d3065 25 Apr 2020 avatar astridx wip
0392e70 25 Apr 2020 avatar astridx wip
avatar astridx astridx - open - 25 Apr 2020
avatar astridx astridx - change - 25 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2020
Category Administration com_modules Templates (admin) Libraries
avatar coolcat-creations
coolcat-creations - comment - 25 Apr 2020

As far as I remember we tried to get rid of icon fonts in favour of svg ... not sure

avatar C-Lodder
C-Lodder - comment - 25 Apr 2020

So all <select> elements need to be wrapped within a parent <div> to have a custom icon?

avatar infograf768
infograf768 - comment - 25 Apr 2020

As far as I remember we tried to get rid of icon fonts in favour of svg ... not sure

svg are a pity to cope with, specially as background as we can't modify the color except if we create other svgs.
Icons are much much easier to deal with for devs/ bug fix

avatar Quy
Quy - comment - 25 Apr 2020

What about the frontend? It should not be dependent of fontawesome.

avatar astridx astridx - change - 10 May 2020
Labels Added: ? ?
avatar astridx
astridx - comment - 10 May 2020

I just resolved a conflict in this draft. I became aware of the topic again. I think we just need a decision here. Otherwise, a contributor will do something that someone else will undo because he likes something else ...

These solutions are in my opinion technically better than this draft:
#28262
#28351

I made this draft because I think the solution in the draft is easier. Sometimes this is also advantageous (#28787 (comment)).

@coolcat-creations
As far as I remember we tried to get rid of icon fonts in favour of svg ... not sure

Thank you for your feedback. You sure know more than I do. I wonder why you yourself continue to work with icon fonts instead of proposing a solution with SVGs: https://github.com/joomla/joomla-cms/pull/29016/files

@Quy What about the frontend? It should not be dependent of fontawesome.

You're right. Thank you Quy. But this draft is only about Atum, i.e. the backend.

@C-Lodder So all <select> elements need to be wrapped within a parent <div> to have a custom icon?

Yes. But in the case of https://github.com/jshjohnson/Choices, an already existing div is used.

avatar Quy
Quy - comment - 10 May 2020

But this draft is only about Atum, i.e. the backend.

But why do it differently on the backend and frontend for the same thing?

avatar astridx astridx - change - 11 May 2020
The description was changed
avatar astridx astridx - edited - 11 May 2020
avatar astridx
astridx - comment - 4 Jul 2020

My solution is not a good one. I'm closing this here. #28673 is not solved and should be reopened.

avatar astridx astridx - close - 4 Jul 2020
avatar astridx astridx - change - 4 Jul 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-07-04 06:58:38
Closed_By astridx
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2020
Category Administration com_modules Templates (admin) Libraries Administration com_modules Templates (admin) NPM Change Libraries

Add a Comment

Login with GitHub to post a comment