User tests: Successful: Unsuccessful:
Draft as basis for a discussion because of #28680 (comment) and #28755 (comment) .
(alternative for #28755 and #28680).
Also see:#28673
I implemented an idea of how we can use an Icon Font instead of SVGs
At the moment this is a RFC.
Basically I prefer SVGs. But I think that the maintenance in an open source project with an icon font is easier.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_modules Templates (admin) Libraries |
So all <select>
elements need to be wrapped within a parent <div>
to have a custom icon?
As far as I remember we tried to get rid of icon fonts in favour of svg ... not sure
svg are a pity to cope with, specially as background as we can't modify the color except if we create other svgs.
Icons are much much easier to deal with for devs/ bug fix
What about the frontend? It should not be dependent of fontawesome.
Labels |
Added:
?
?
|
I just resolved a conflict in this draft. I became aware of the topic again. I think we just need a decision here. Otherwise, a contributor will do something that someone else will undo because he likes something else ...
These solutions are in my opinion technically better than this draft:
#28262
#28351
I made this draft because I think the solution in the draft is easier. Sometimes this is also advantageous (#28787 (comment)).
@coolcat-creations
As far as I remember we tried to get rid of icon fonts in favour of svg ... not sure
Thank you for your feedback. You sure know more than I do. I wonder why you yourself continue to work with icon fonts instead of proposing a solution with SVGs: https://github.com/joomla/joomla-cms/pull/29016/files
@Quy What about the frontend? It should not be dependent of fontawesome.
You're right. Thank you Quy. But this draft is only about Atum, i.e. the backend.
@C-Lodder So all
<select>
elements need to be wrapped within a parent<div>
to have a custom icon?
Yes. But in the case of https://github.com/jshjohnson/Choices, an already existing div is used.
But this draft is only about Atum, i.e. the backend.
But why do it differently on the backend and frontend for the same thing?
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-04 06:58:38 |
Closed_By | ⇒ | astridx |
Category | Administration com_modules Templates (admin) Libraries | ⇒ | Administration com_modules Templates (admin) NPM Change Libraries |
As far as I remember we tried to get rid of icon fonts in favour of svg ... not sure