[#28786] - [4.0] Atum - Change hardcoded class of delete button and add as parameter
- Fixed in Code Base
- 25 Apr 2020
- Medium
- Build: 4.0-dev
- # 28786
- Diff
- coolcat-creations:delete-button-templatemanager
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28263
Summary of Changes
Added a parameter $class to the modal buttons with default to btn-primary
Added the class btn-danger to the delete button
Testing Instructions
Apply the patch
Go to the template Manager into the files edit section, select a file and see if the delete file button is red (icon and hover)
Expected result
Button has class btn-danger and hovers red
Actual result
Button has class btn-primary and hovers blue
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates Libraries |
| Title |
|
||||||
Insert on line 699
* @param string $class The button class
| Labels |
Added:
?
|
||
Insert on line 699
* @param string $class The button class
Thank you
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28786.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28786.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28786.
PHPCS errors!
Please correct cs
| Status | Ready to Commit | ⇒ | Pending |
Back to pending
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28786.
Fixed the PHPCS. I hope @coolcat-creations allowed me.
| Status | Pending | ⇒ | Ready to Commit |
RTC
as changes was only CS
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28786.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-25 15:34:42 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks all.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28786.
@coolcat-creations PHPCS check by drone complains that there is a doc block comment missing for the new parameter. You know how to fix that? If not, ping me.