?
avatar gerryfrancis
gerryfrancis
11 Apr 2020

Steps to reproduce the issue

Choose "Protostar" as the frontend template for your site.
Load your site frontend and log in as an editor.
Edit any article to load the article editor.
Take a look at the group of buttons "Save", "Cancel", and "Versions".

Expected result

grafik
The button radius is equal to each other.

Actual result

grafik
The button radius is not equal to each other.

System information (as much as possible)

Joomla! 3.9.16.
PHP 7.2.

Additional comments

From English to German:
"Save" -> "Speichern".
"Cancel" -> "Abbrechen".
"Versions" -> "Versionen".

avatar gerryfrancis gerryfrancis - open - 11 Apr 2020
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 11 Apr 2020
avatar gerryfrancis gerryfrancis - change - 11 Apr 2020
The description was changed
avatar gerryfrancis gerryfrancis - edited - 11 Apr 2020
avatar jwaisner jwaisner - change - 14 Apr 2020
Priority Medium Very low
Status New Confirmed
avatar jwaisner
jwaisner - comment - 14 Apr 2020

Confirmed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28659.

avatar jwaisner jwaisner - change - 14 Apr 2020
Category Layout
avatar gerryfrancis
gerryfrancis - comment - 15 Apr 2020

Unfortunately I have no coding skills, but I have recognized that each of these buttons has its own div.btn-group in Protostar, which is different to the Isis backend.

All three buttons in one div.btn-group would look like this:

grafik

(Note: I changed .btn-group > .btn + .btn to .btn-group > .btn in "template.css" to have margin-left: -1px; for the last button as well.)

Pressing "Versions" opens a modal showing such a toolbar, in case someone would like to compare.

If I only knew how and where to modify JS to access div.btn-group div#versionsModal...

avatar infograf768
infograf768 - comment - 16 Apr 2020

In fact, it could be done via a bootstrap override in cassiopea protostar template.less

// Need .dropdown-toggle since :last-child doesn't apply given a .dropdown-menu immediately after it
.btn-group > .btn:last-child,
.btn-group > .dropdown-toggle {
  .border-top-right-radius(@baseBorderRadius);
  .border-bottom-right-radius(@baseBorderRadius);
  .border-top-left-radius(@baseBorderRadius);
  .border-bottom-left-radius(@baseBorderRadius);
}

just before
@import "template_rtl.less"; // Specific for rtl. Always load last.

then running generatecss.php to get
Screen Shot 2020-04-16 at 08 38 26

But it should be tested all over to know if unwanted consequences

avatar gerryfrancis
gerryfrancis - comment - 16 Apr 2020

@infograf768 Thank you for your hint. Do you think this will work for Protostar, too?

avatar infograf768
infograf768 - comment - 16 Apr 2020

sorry this was for protostar...
(Cassiopea in J4 does not use less files, but scss)
I correct post above

avatar gerryfrancis
gerryfrancis - comment - 16 Apr 2020

@infograf768 Never mind.

I guess I better wait for a fix that may be included in one of the next minor updates. Unfortunately I do not have access to the PHP console, and it is not that important, anyway. If someone likes to work on this, I will be very pleased of course. :)

avatar brianteeman
brianteeman - comment - 24 Dec 2020

Please test #31776

avatar Quy Quy - change - 24 Dec 2020
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2020-12-24 10:20:59
Closed_By Quy
avatar Quy Quy - close - 24 Dec 2020
avatar gerryfrancis
gerryfrancis - comment - 13 Jan 2021

Thanks a lot, folks! What a nice Christmas present! ?

Add a Comment

Login with GitHub to post a comment