[#28658] - [4.0][Atum] Choices CSS rewrite
- Fixed in Code Base
- 12 Apr 2020
- Medium
- Build: 4.0-dev
- # 28658
- Diff
- ciar4n:choices-style
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28648, #28461, #23451.
Summary of Changes
Rewrites choices CSS
- Reduced CSS
- Simplifies styling
- Removes 'Press to Select' text
- Matches style with non choices select fields
Removes placholder text if 1+ item selected.
Testing Instructions
Apply this patch and run node build.js --compile-css for updating the changed SCSS. Check choices select fields (searchtools / new article -> category)
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28658.
I've tested also RTL ... I hope I haven't missed anything. Maybe @infograf768 could test, too, so we can be sure it is ok for RTL?
Seems I need glasses.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28658.
| Labels |
Added:
?
|
||
@brianteeman Should be fine now (267c7fa).
border radius and focus all good now.
The text color is still different
for choices it is the placeholder that needs to be changed
What browser are you using?.. color is the same but browser style applying opacity. Thought i reset it but obviously not.
chrome on windows
Thx. I'll check again in the morn.
I guess should also be tested with Cassiopea
Placeholder color should be now correct.
All current changes are only made in Atum
awesome sauce - i can confirm the placeholder is correct now
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-12 17:22:36 |
| Closed_By | ⇒ | wilsonge |
@infograf768 PR created... #28676
not sure if my test cover what you have fixed here anyway
i'm in com_modules
selecting some of those and then click on batch and then look at Set Position