? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
11 Apr 2020

Summary of Changes

In users batch modal:
There is a label for the button group "password reset" but it is not related to the following buttpn group.
This PR adds a label-for and a fieldset to the radio button group.

Testing Instructions

Code review, there are noch cahnges visible on the screen.
The label must be related to a fieldset as it shown here:

batch-fieldset users

avatar chmst chmst - open - 11 Apr 2020
avatar chmst chmst - change - 11 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2020
Category Administration com_users
avatar chmst chmst - change - 11 Apr 2020
Priority Medium Low
Labels Added: ?
Easy No Yes
avatar richard67
richard67 - comment - 11 Apr 2020

I have tested this item successfully on a7623b6

Code review + inspection of html in browser's developer tools after having applied the patch of this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28657.

avatar brianteeman
brianteeman - comment - 11 Apr 2020

I have tested this item successfully on a7623b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28657.

avatar richard67 richard67 - test_item - 11 Apr 2020 - Tested successfully
avatar brianteeman brianteeman - test_item - 11 Apr 2020 - Tested successfully
avatar richard67 richard67 - change - 11 Apr 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28657.

avatar wilsonge wilsonge - change - 11 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-11 20:57:31
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 11 Apr 2020
avatar wilsonge wilsonge - merge - 11 Apr 2020
avatar wilsonge
wilsonge - comment - 11 Apr 2020

Thanks!

Add a Comment

Login with GitHub to post a comment