? ? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
11 Apr 2020

Summary of Changes

Improves the language strings for installing an extra language. Now that we don't install sample data we don't need to call it customising. We can strictly call it installing extra languages.

Testing Instructions

View strings in installer should be as below after patch

Expected result

Screenshot 2020-04-11 at 18 33 19

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 11 Apr 2020
avatar wilsonge wilsonge - change - 11 Apr 2020
Status New Pending
avatar wilsonge wilsonge - change - 11 Apr 2020
Title
Improve strings for adding an extra language
[4.0] Improve strings for adding an extra language
avatar wilsonge wilsonge - edited - 11 Apr 2020
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2020
Category Installation Language & Strings
avatar richard67
richard67 - comment - 11 Apr 2020

@wilsonge Well it is not only installation of languages. At the end you also have to select default languages for site and admin. So that's some kind of customization. But I am ok with both, like it is and like it will be with this PR.

avatar brianteeman
brianteeman - comment - 11 Apr 2020

Two comments

  1. Would it not be better as "Install Extra Languages" or "Install Additional Languages"

  2. We still have the crazy situation that you have gone through the entire installation process in your own language eg french and then you get this message. Why would I even think to install another language - this is french. Except its not french its all in english as soon as you complete the installation. Other CMS either offer you a download in your language or ask you what language you want to be installed as PART of the process and not as an additional step after you have completed the install

avatar wilsonge wilsonge - change - 11 Apr 2020
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 11 Apr 2020

Would it not be better as "Install Extra Languages" or "Install Additional Languages"

Done

We still have the crazy situation that you have gone through the entire installation process in your own language eg french and then you get this message. Why would I even think to install another language - this is french. Except its not french its all in english as soon as you complete the installation. Other CMS either offer you a download in your language or ask you what language you want to be installed as PART of the process and not as an additional step after you have completed the install

So I'm not the biggest fan either - but the reality is that our install language functionality depends on loading this data from the updates which requires a CMS install. I'd like to find a way to make it easier to install the language you're using in the installer (at minimum promote the language to the top of the list). But from a technical perspective at this moment in time I don't think we'll be able to move this to something that happens during the install UNLESS after the DB installation we artificially add a step before showing the success message.

avatar brianteeman
brianteeman - comment - 11 Apr 2020

As you and I are the only people who have ever raised a comment on this and we never install joomla in other languages I guess its not worth the time and effort to resolve that


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28656.

avatar brianteeman
brianteeman - comment - 11 Apr 2020

I have tested this item successfully on 52dadfd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28656.

avatar brianteeman brianteeman - test_item - 11 Apr 2020 - Tested successfully
avatar richard67
richard67 - comment - 11 Apr 2020

I have tested this item successfully on 52dadfd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28656.

avatar richard67 richard67 - test_item - 11 Apr 2020 - Tested successfully
avatar richard67 richard67 - change - 11 Apr 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28656.

avatar wilsonge wilsonge - change - 11 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-11 18:46:49
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 11 Apr 2020
avatar wilsonge wilsonge - merge - 11 Apr 2020
avatar wilsonge
wilsonge - comment - 11 Apr 2020

Thanks!

Add a Comment

Login with GitHub to post a comment