I tried a test.

1. git fetch origin pull/28660/head:feature/upgrade-composer

2. git checkout feature/upgrade-composer

3. I deleted the folder /libraries/vendor and run composer i and npm ci

4. I made a new installation and discovered a custom component and some language packages. That was OK.

5. I created an item in my custom component. That was OK.

6. I created a new article, make it feature and published. Then I changed to the font end. Everything was fine.

7. I run some tests with my acceptance.yml. I use Firefox for the tests.
   acceptance.txt

Here I encountered errors.

 ./node_modules/.bin/selenium-standalone install

 ./node_modules/.bin/selenium-standalone start

$ libraries/vendor/bin/codecept run acceptance tests/Codeception/acceptance/01-install/

The browser opened automatically and it starts entering data. But the installation was not OK. I finished the installation manually.

$ libraries/vendor/bin/codecept run acceptance tests/Codeception/acceptance/administrator/

admin.txt

$ libraries/vendor/bin/codecept run acceptance tests/Codeception/api/

The browser opened automatically, but now URL was entered.
api.txt

Now I am not sure if I am doing something wrong or if the tests are not up to date.

The browser opened automatically and it starts entering data. But the installation was not OK. I finished the installation manually.

Seems weird because I can install ok and so can drone. what exactly failed. i mean i'm upgrading codeception a major version so anything is possible but i need more information to work with I'm afraid

@rdeutz @Hackwar i'll need help with the system tests failing on media manager after this change

After testing everything looks good.

*Tested Clean install of Joomla!
*Set error reporting to Maximum
*Installed sample data
*Installed multiple extensions
*created articles, categories, fields, menus, modules, users, and usergroups with no issues
*Deleted the above with no issues
*Indexed using smart search followed by a purge and rebuild with no issues

I am not familiar with system tests so I did not complete those.

System Info:
*OS - Windows 10
*Database - mysql 5.7.26
*PHP 7.4.4

I have tested this item ✅ successfully on b9b49ec

@wilsonge System tests still failing here. Would it help if you update your branch to latest 4.0-dev?

@wilsonge System tests still failing here. Would it help if you update your branch to latest 4.0-dev?

It is up to date unfortunately

@Hackwar going to need some help here i think

Looking at the tests, I have no idea why it fails. :-) I installed the same branch and it works fine, but most importantly, according to the screenshot it loads the wrong folder in the media manager.

Why do we have the changes to InputFilter and SafeHtml in this PR? Shouldn't that be a separate PR?

I have an assumption and would ask you to check this for me. (I don't want to copy your PR and setup all this, etc...)

It seems as if waitForMediaLoaded() in tests/Codeception/_support/Step/Acceptance/Administrator/Media.php waits for NoSuchElementException and the methods used here don't throw that exception anymore. Maybe simply try with Exception?

Why do we have the changes to InputFilter and SafeHtml in this PR? Shouldn't that be a separate PR?

It’s a fallout from going from framework v1 to v2. getInstance is defined in the cms but for some reason the instances static was in the framework. We removed it so it needs to be added here. Safe html is because we typehint the constructor of input filter as array so the null being passed in failed

@wilsonge The browser opened automatically and it starts entering data. But the installation was not OK. I finished the installation manually.

Seems weird because I can install ok and so can drone. what exactly failed. i mean i'm upgrading codeception a major version so anything is possible but i need more information to work with I'm afraid

I just tested it with chrome. With chrome the installation is fine.

I only looked briefly, but maybe it helps: The Media Manager Check works for me if I comment out the two lines $I->waitForMediaLoaded(); in the file Joomla4/tests/Codeception/acceptance/administrator/components/com_media/MediaListCest.php

	/**
	 * Test check all items.
	 *
	 * @param   Media  $I  Acceptance Helper Object
	 *
	 * @since   4.0.0
	 *
	 * @throws Exception
	 */
	public function deleteMultipleFiles(Media $I)
	{
		$testFileName1 = 'test-image-1.png';
		$testFileName2 = 'test-image-1.jpg';
		$testFileItem1 = MediaListPage::item($testFileName1);
		$testFileItem2 = MediaListPage::item($testFileName2);

		$I->wantToTest('that it is possible to delete multiple files.');
		$I->amOnPage(MediaListPage::$url . $this->testDirectory);
		$I->uploadFile('com_media/' . $testFileName1);
		$I->seeAndCloseSystemMessage('Item uploaded.');
		$I->wait(10);
		$I->waitForElement($testFileItem1);

		// We have to clear the file input, otherwise our method of uploading the file via Codeception will upload it twice
		$I->executeJS('document.getElementsByName(\'file\')[0].value = \'\'');
		//$I->waitForMediaLoaded();
		$I->uploadFile('com_media/' . $testFileName2);
		$I->seeAndCloseSystemMessage('Item uploaded.');
		$I->wait(10);
		//$I->waitForMediaLoaded();
		$I->waitForElement($testFileItem2);
		$I->click($testFileItem1);
		$I->clickHoldingShiftkey($testFileItem2);
		$I->click(MediaListPage::$toolbarDeleteButton);
		$I->waitForElement(MediaListPage::$toolbarModalDeleteButton);
		$I->click(MediaListPage::$toolbarModalDeleteButton);
		$I->seeSystemMessage('Item deleted.');
		$I->waitForElementNotVisible($testFileItem1);
		$I->waitForElementNotVisible($testFileItem2);
		$I->dontSeeElement($testFileItem1);
		$I->dontSeeElement($testFileItem2);
	}

That was the hint i needed fixed

I have tested this item ✅ successfully on f7023a0

Retested after latest change and everything still works as expected.

Thanks