? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
3 Mar 2020

Summary of Changes

Fixes incorrect layout being used when trying to edit profile in some cases.

Couple of things that might need to be discussed. This was done with assumptions that:

  1. Routing changes in 4.0 are correct and the active menu item must always be set.

  2. We don't want users changing the layout via input.

If both assumptions are wrong we can remove this code from the view and let the controller handle it.

Testing Instructions

Create Articles - Category Blog menu item. Set it as Home page.
Enable System - Privacy Consent plugin.
Log in to frontend.

Expected result

Redirected to user profile form.

Actual result

Redirected to profile page. Clicking Edit Profile leaves us on the same page.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 3 Mar 2020
avatar SharkyKZ SharkyKZ - change - 3 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2020
Category Front End com_users
avatar alikon
alikon - comment - 4 Mar 2020

i'm unable to replicate the behaviour , i was redrected as expected to the profile for expressing the consent

avatar SharkyKZ
SharkyKZ - comment - 4 Mar 2020

Did you try this on clean installation? And did you set Category Blog as your home page?

avatar alikon
alikon - comment - 4 Mar 2020

yes
just sample blog data

avatar SharkyKZ
SharkyKZ - comment - 4 Mar 2020

If using blog sample data, unpublish Change Password menu item.

avatar alikon
alikon - comment - 4 Mar 2020

weird
now i'm able to replicate the issue

avatar alikon
alikon - comment - 4 Mar 2020

I have tested this item successfully on a03abd5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28194.

avatar alikon alikon - test_item - 4 Mar 2020 - Tested successfully
avatar lefabdu51
lefabdu51 - comment - 5 Mar 2020

I have tested succesfully this one via patch tester, but when i go to issues.joomla.org, i have a bug and i can't signal my result. I have this message when the page is downloaded from the cdn : "Could not load template section." The layout is broken and i have no button to submit my result. Where should i signal this ?

avatar brianteeman
brianteeman - comment - 5 Mar 2020

Currently there is an outage on the CDN which is why you had that error.

avatar jwaisner
jwaisner - comment - 5 Mar 2020

I have tested this item successfully on a03abd5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28194.

avatar jwaisner jwaisner - test_item - 5 Mar 2020 - Tested successfully
avatar jwaisner jwaisner - change - 5 Mar 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 5 Mar 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28194.

avatar lefabdu51
lefabdu51 - comment - 6 Mar 2020

I have tested this item successfully on a03abd5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28194.

avatar lefabdu51
lefabdu51 - comment - 6 Mar 2020

I have tested this item successfully on a03abd5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28194.

avatar lefabdu51 lefabdu51 - test_item - 6 Mar 2020 - Tested successfully
avatar lefabdu51 lefabdu51 - test_item - 6 Mar 2020 - Tested successfully
avatar richard67 richard67 - change - 8 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-08 19:17:12
Closed_By richard67
Labels Added: ? ?
avatar richard67 richard67 - close - 8 Mar 2020
avatar richard67 richard67 - merge - 8 Mar 2020
avatar richard67
richard67 - comment - 8 Mar 2020

Thanks.

Add a Comment

Login with GitHub to post a comment