[#28193] - [4.0] RTL: Fixing Main Menu star icon display in Menus Dashboard
- Fixed in Code Base
- 8 Mar 2020
- Medium
- Build: 4.0-dev
- # 28193
- Diff
- infograf768:4.0_rtl_cpanel_star
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Forgot to deal with the star icon in rtl in #28131
Testing Instructions
Make sure you have a Main Menu with home set to All languages.
Install Persian language.
Switch to Persian in back-end.
Display the Menus Dashboard
Patch and use npm ci
Before patch
After patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
|
||
hmm
my mistake, should use inline-block.
correcting now
Please test.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28193.
Can you remove the hover on line 200-202 please as well. (If not I can do it in a separate pr)
| Labels |
Added:
?
Removed: NPM Resource Changed |
||
hover removed, inline-block used for both rtl and ltr
Please test (again) ;)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28193.
@ciar4n @brianteeman
Please one more test to get rid of this small pr. :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28193.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28193.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-08 18:07:17 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks.
I am surprised you need flow-root on RTL but not on LTR - also it is not supported on i0S