[#28195] - Fix for missing Fulltext Image in Newsfeeds
- Closed
- 12 Jun 2022
- Medium
- Build: staging
- # 28195
- Diff
- AndySDH:patch-9
- Success Hound Smells good to me. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr Build is failing Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Originally Joomla RSS Newsfeeds were completely missing the image_intro and image_fulltext. This was partially fixed with this PR: #11402
But that only introduced the image_intro, and forgot the image_fulltext.
So an article that had an image_fulltext would not use that image in the feed.
This PR simply adds the image_fulltext to the feed if the image_intro is empty.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
That was intentional. Fulltext image is not used in category views.
Right, but that shouldn't matter. This is a newsfeed of the articles contained in the category. So I believe the main image representing the article should show in a feed list of the articles.
I have had this problem too, we work with websites that are in Google News.
It is very important to have a really good feed.
https://support.google.com/news/publisher-center/answer/9545245
| Labels |
Added:
?
|
||
I need the image path in a separate tag. and not along with the introduction text.
Formatio-hippocampi
- 
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28195.
Hello, we need one more successful test for this. Or anything else I need to do to get this merged?
gostn
-
Thanks guys, asking for this to be merged after the successful tests have been made
humm,
drone still failing, but most probably is not related to your pr
Not for the variable, for the object property.
I'm not going to make any changes because 1) I don't have such privilege 2) this PR is wrong as already explained in the first comment.
But if maintainers accept this change, it at least should not be producing PHP notices:
PHP Notice: Trying to get property of non-object in C:\wamp\www\joomla-cms-3\components\com_content\views\category\view.feed.php on line 42
The PR is not wrong. f you google around you find many people complaining about this same issue.
Anyway, I'll make the changes, I'll also make the code a little bit more nice to read.
Not sure why checks are failing, anyone can help?
please merge the current staging branch into this pr branch
@HLeithner can you give me instructions on how to do it? No idea how that's done =/ Thanks.
Soo... Can someone with the knowledge to do this merge this into the latest branch? Thanks!
Hello, any update on this?
| Labels |
Added:
?
?
Removed: ? |
||
I'm sorry that it took that long to get a reply here but i will not accept this PR as it is into 3.10. if anything we should do a new PR against 4.2-dev.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-12 17:33:55 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Removed:
?
|
||
That was intentional. Fulltext image is not used in category views.