Joomla! Issue Tracker | Joomla! CMS #28084 - [4.0] Cassiopea duplicate site-grid

Closed
26 Feb 2020
Medium
Build: staging
# 28084

brianteeman
26 Feb 2020

.site-grid has two competing values for grid-template-areas

Obviously this is wrong but which is the one that should be removed?

joomla-cms/templates/cassiopeia/scss/blocks/_css-grid.scss

Lines 6 to 17 in cf8a75e

    
           grid-template-areas: 
        
             ". head head head head ." 
        
             ". banner banner banner banner ." 
        
             ". comp comp comp comp ." 
        
             ". side-l side-l side-l side-l ." 
        
             ". side-r side-r side-r side-r ." 
        
             ". top-a top-a top-a top-a ." 
        
             ". top-b top-b top-b top-b ." 
        
             ". bot-a bot-a bot-a bot-a ." 
        
             ". bot-b bot-b bot-b bot-b ." 
        
             ". footer footer footer footer ." 
        
             ". debug debug debug debug .";

joomla-cms/templates/cassiopeia/scss/blocks/_css-grid.scss

Lines 51 to 61 in cf8a75e

    
           grid-template-areas: ". head head head head ." 
        
           ". banner banner banner banner ." 
        
           ". top-a top-a top-a top-a ." 
        
           ". top-b top-b top-b top-b ." 
        
           ". comp comp comp comp ." 
        
           ". side-r side-r side-r side-r ." 
        
           ". side-l side-l side-l side-l ." 
        
           ". bot-a bot-a bot-a bot-a ." 
        
           ". bot-b bot-b bot-b bot-b ." 
        
           ". footer footer footer footer ." 
        
           ". debug debug debug debug .";

brianteeman - open - 26 Feb 2020

joomla-cms-bot - change - 26 Feb 2020

Labels

Added: ?

joomla-cms-bot - labeled - 26 Feb 2020

C-Lodder - comment - 26 Feb 2020

The 2nd one is wrapped in a media query:

@include media-breakpoint-up(md) { ... }

The difference is in the sidebars

brianteeman - comment - 26 Feb 2020

@C-Lodder no that's the third one

ciar4n - comment - 26 Feb 2020

My bad. The second is what is currently applied so I guess you could go with that. I would move it to the top in place of the first.

The difference in the 2 is that the first places the bulk of the modules after the component on small screen devices. The second one has them in the same order as desktop.

brianteeman - comment - 26 Feb 2020

ok @ciar4n thanks for confirming

brianteeman - change - 26 Feb 2020

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2020-02-26 09:56:15
Closed_By		⇒	brianteeman

brianteeman - close - 26 Feb 2020

C-Lodder - comment - 26 Feb 2020

Oh sorry, I didn't notice a third one

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#28084] - [4.0] Cassiopea duplicate site-grid

Add a Comment

	grid-template-areas:
	". head head head head ."
	". banner banner banner banner ."
	". comp comp comp comp ."
	". side-l side-l side-l side-l ."
	". side-r side-r side-r side-r ."
	". top-a top-a top-a top-a ."
	". top-b top-b top-b top-b ."
	". bot-a bot-a bot-a bot-a ."
	". bot-b bot-b bot-b bot-b ."
	". footer footer footer footer ."
	". debug debug debug debug .";

	grid-template-areas: ". head head head head ."
	". banner banner banner banner ."
	". top-a top-a top-a top-a ."
	". top-b top-b top-b top-b ."
	". comp comp comp comp ."
	". side-r side-r side-r side-r ."
	". side-l side-l side-l side-l ."
	". bot-a bot-a bot-a bot-a ."
	". bot-b bot-b bot-b bot-b ."
	". footer footer footer footer ."
	". debug debug debug debug .";