Feeling Lucky
?
[#28083] - [4.0] lint fractional units
- Fixed in Code Base
- 26 Feb 2020
- Medium
- Build: 4.0-dev
- # 28083
- Diff
- brianteeman:lint
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Now that we finally have scss-lint running on this repo (after several years of it being ignored) #28076 has revealed several issues that are because of an outdated linter and rules
as of scss-lint 0.59 (there is a pr for this from @ciar4n ) support has been added to test for fractional units (the fr thing used in grids)
This PR adds the test for fr units to our scss lint rules
reference https://github.com/sds/scss-lint/blob/master/config/default.yml
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-26 10:16:35 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
brianteeman
- comment
- 26 Feb 2020
thanks
Thanks!