? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Feb 2020

Pull Request for Issue #28043

This Pr moves the border bottom on the sidebar items so that it only appears on hover.

As can be seen below where I have changed the border to red for clarity it was on the wrong element

requires npm i or node build.js --compile-css to test

before

before

after

after

avatar brianteeman brianteeman - open - 24 Feb 2020
avatar brianteeman brianteeman - change - 24 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2020
Category Administration Templates (admin)
avatar Quy
Quy - comment - 24 Feb 2020

I have tested this item successfully on 225d42b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28054.

avatar Quy Quy - test_item - 24 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 24 Feb 2020

I have tested this item successfully on 225d42b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28054.

avatar jwaisner jwaisner - test_item - 24 Feb 2020 - Tested successfully
avatar jwaisner jwaisner - change - 24 Feb 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 24 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28054.

avatar ciar4n
ciar4n - comment - 24 Feb 2020

You will need to include a transparent border to the non hover state. This currently causes a 1px jump on items below the hovered item.

avatar rdeutz
rdeutz - comment - 24 Feb 2020

You will need to include a transparent border to the non hover state. This currently causes a 1px jump on items below the hovered item.

@brianteeman can you have a look at this, thanks

avatar brianteeman brianteeman - change - 24 Feb 2020
Labels Added: ?
avatar brianteeman
brianteeman - comment - 24 Feb 2020

@ciar4n @rdeutz thanks and done

avatar wilsonge wilsonge - change - 24 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-24 22:55:52
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 24 Feb 2020
avatar wilsonge wilsonge - merge - 24 Feb 2020
avatar wilsonge
wilsonge - comment - 24 Feb 2020

Thanks!

avatar brianteeman
brianteeman - comment - 24 Feb 2020

thanks

Add a Comment

Login with GitHub to post a comment