? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
24 Feb 2020

Fixes #27828 and #26947.

Summary of Changes

Append ID to redirect URL so it doesn't get lost.
Clear session data when applying changes to load data from database.

Testing Instructions

Create two menus (menu1 and menu2).
Edit menu2.
Change its Menu Type to menu1.
Click Save.
After saving fails, change its menu type to menu3 and save.
View menus.

Edit a menu.
Remove its menu type.
Use browser tools to circumvent JS validation (remove required class and attribute from menu type field).
Click Save.
After saving fails, edit menu type back to what it was.
Save.

Expected result

  1. menu2 type changed to menu3.
  2. Menu saved.

Actual result

  1. A new menu with type menu3 is created.
  2. Saving fails with error: Save failed with the following error: Menu type exists:...

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 24 Feb 2020
avatar SharkyKZ SharkyKZ - change - 24 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2020
Category Administration com_menus
avatar SharkyKZ SharkyKZ - change - 24 Feb 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 24 Feb 2020
avatar joomdonation
joomdonation - comment - 25 Feb 2020

I have tested this item successfully on 1a681df


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28053.

avatar joomdonation joomdonation - test_item - 25 Feb 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 25 Feb 2020

I have tested this item successfully on 1a681df


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28053.

avatar infograf768 infograf768 - test_item - 25 Feb 2020 - Tested successfully
avatar infograf768 infograf768 - change - 25 Feb 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 25 Feb 2020

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28053.

avatar rdeutz rdeutz - close - 25 Feb 2020
avatar rdeutz rdeutz - merge - 25 Feb 2020
avatar rdeutz rdeutz - change - 25 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-25 22:39:15
Closed_By rdeutz
Labels Added: ? ?

Add a Comment

Login with GitHub to post a comment