? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Feb 2020

There is no need to have these overrides. We really shouldnt have to create overrides for the core templates and it is a maintenance headache.

This PR removes the overrides and puts the two tiny changes back into the core files.

For reference the changes are

  1. Edit Article
    Remove the box shadow around the wysiwyg area
  2. Article Manager
    Change the size of the text for the status text to small
avatar brianteeman brianteeman - open - 24 Feb 2020
avatar brianteeman brianteeman - change - 24 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2020
Category Administration com_content Templates (admin)
avatar Quy
Quy - comment - 24 Feb 2020

I have tested this item successfully on 3dbe6c8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28052.

avatar Quy Quy - test_item - 24 Feb 2020 - Tested successfully
avatar richard67
richard67 - comment - 25 Feb 2020

I have tested this item successfully on 3dbe6c8

Code review: The changes made by this PR to the core files are equal to the differences between the removed override files and their corresponding core files, plus the error with empty css class is corrected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28052.

avatar richard67 richard67 - test_item - 25 Feb 2020 - Tested successfully
avatar richard67 richard67 - change - 25 Feb 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 25 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28052.

avatar richard67 richard67 - change - 25 Feb 2020
Labels Added: ? ?
avatar rdeutz rdeutz - change - 25 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-25 22:40:40
Closed_By rdeutz
Labels
avatar rdeutz rdeutz - close - 25 Feb 2020
avatar rdeutz rdeutz - merge - 25 Feb 2020
avatar brianteeman
brianteeman - comment - 25 Feb 2020

Thanks everyone

Add a Comment

Login with GitHub to post a comment