? ? Pending

User tests: Successful: Unsuccessful:

avatar simbus82
simbus82
24 Feb 2020

Pull Request for issue #26312

Why

https://support.google.com/webmasters/answer/96569?hl=en
Advanced users (copywriters, bloggers, etc.) are very concerned about SEO.
Their projects often live thanks to affiliation, sponsorship and advertising.
It is important to provide them with all the tools necessary for a correct supply of information to the search engine, so as not to be penalized and to constantly improve aspects such as indexing and positioning.
These two options specifically help Google identify the behavior of outbound links from Joomla sites, thus providing correct information on what to expect from the connected external source.

Summary of Changes

Add new "sponsored" and "ugc" options to rel attribute of external URL menu type.

Testing Instructions

Add new menu item
Select System Links > URL
Click Link Type tab
Click Link Rel Attribute dropdown
See spondored and ugc option

Next Step (not in this PR)

Users should select more than one option for "rel" attribute.
https://www.w3.org/TR/html401/struct/links.html#adef-rel

rel = link-types [CI]
This attribute describes the relationship from the current document to the anchor specified by the href attribute.
The value of this attribute is a space-separated list of link types.

avatar simbus82 simbus82 - open - 24 Feb 2020
avatar simbus82 simbus82 - change - 24 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2020
Category Administration com_menus
avatar brianteeman
brianteeman - comment - 24 Feb 2020

Please add them in alphabetical order and not just randomly insert in the middle

avatar simbus82 simbus82 - change - 24 Feb 2020
Labels Added: ?
avatar simbus82
simbus82 - comment - 24 Feb 2020

Sorry, i added the options with a "logical" positioning (not randomly): now are alphabetically ordered.
Thanks!

avatar simbus82
simbus82 - comment - 24 Feb 2020

I have tested this item successfully on 9246379

Tested successfully with Joomla 3.9.15, works well in Isis Backend.

Tested successfully (if the rel is present) in frontend with beez3, protostar and a custom template.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28055.

avatar simbus82 simbus82 - test_item - 24 Feb 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 24 Feb 2020

@simbus82 For obvious reasons we dont mark successful tests on our own code. Obviously it is already assumed that you tested your code when you submitted it

avatar richard67 richard67 - alter_testresult - 24 Feb 2020 - simbus82: Not tested
avatar richard67
richard67 - comment - 24 Feb 2020

@simbus82 Altered your test result to "not tested" in the issue tracker due to reason @brianteeman explained above.

avatar Quy
Quy - comment - 24 Feb 2020

I have tested this item successfully on 9246379


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28055.

avatar Quy
Quy - comment - 24 Feb 2020

I have tested this item successfully on 9246379


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28055.

avatar Quy Quy - test_item - 24 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 24 Feb 2020

I have tested this item successfully on 9246379


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28055.

avatar jwaisner jwaisner - test_item - 24 Feb 2020 - Tested successfully
avatar jwaisner jwaisner - change - 24 Feb 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 24 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28055.

avatar zero-24
zero-24 - comment - 24 Feb 2020

Merging thanks ? And thanks @simbus82 for your first contribution to the Joomla Core.

avatar zero-24 zero-24 - close - 24 Feb 2020
avatar zero-24 zero-24 - merge - 24 Feb 2020
avatar zero-24 zero-24 - change - 24 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-24 17:53:16
Closed_By zero-24
Labels Added: ?

Add a Comment

Login with GitHub to post a comment