Feeling Lucky
?
?
[#28047] - [4.0] codestyle
- Fixed in Code Base
- 24 Feb 2020
- Medium
- Build: 4.0-dev
- # 28047
- Diff
- brianteeman:codestyle
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
do not use units when the value is 0 eg 0 not 0px
always have a space after the colon eg color: $red not color:$red
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
ChristineWk
- comment
- 23 Feb 2020
I have tested this item
Code review. There are also in addition other, e.g. sidebar_nav.scss, toolbar.scss etc. (total 8) changed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28047.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 23 Feb 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28047.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-24 07:50:57 |
| Closed_By | ⇒ | rdeutz |
brianteeman
- comment
- 24 Feb 2020
Thanks
I have tested this item✅ successfully on 6a1d2c3
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28047.