? ? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
23 Feb 2020

Pull Request for Issue # #28036.

Summary of Changes

I removed the override for the Toolbar in Autum Template that was created in #27918

In this override the filter was moved before the search int the toolbar. I hope that I not oversee something again. But I see no reason for doing this move. That is why for me the easiest solution is to delete this override.

Testing Instructions

Please see #28032 and test the view on Mobil.

Expected result

Actual result

Documentation Changes Required

53a1271 23 Feb 2020 avatar astridx undo
avatar astridx astridx - open - 23 Feb 2020
avatar astridx astridx - change - 23 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2020
Category Administration Templates (admin)
avatar richard67
richard67 - comment - 23 Feb 2020

I have tested this item successfully on 53a1271


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28046.

avatar richard67 richard67 - test_item - 23 Feb 2020 - Tested successfully
avatar richard67
richard67 - comment - 23 Feb 2020

@astridx I think this fixes #28045 too. Is that right?

avatar brianteeman
brianteeman - comment - 23 Feb 2020

I have tested this item successfully on 53a1271


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28046.

avatar brianteeman brianteeman - test_item - 23 Feb 2020 - Tested successfully
avatar richard67 richard67 - change - 23 Feb 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 23 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28046.

avatar richard67
richard67 - comment - 23 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28046.

avatar richard67 richard67 - change - 23 Feb 2020
Labels Added: ? ?
avatar richard67 richard67 - close - 23 Feb 2020
avatar richard67 richard67 - merge - 23 Feb 2020
avatar richard67 richard67 - change - 23 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-23 21:00:21
Closed_By richard67
Labels
avatar richard67
richard67 - comment - 23 Feb 2020

Thanks.

avatar brianteeman
brianteeman - comment - 23 Feb 2020

@richard67 we usually dont merge a pull request if we are one of the testers.

avatar richard67
richard67 - comment - 23 Feb 2020

@brianteeman I know, but I thought in such a trivial case I can make an exception. I've double checked that it doesn't do any harm.

avatar brianteeman
brianteeman - comment - 23 Feb 2020

it's just good practice

avatar richard67
richard67 - comment - 23 Feb 2020

I'll respect it then.

Add a Comment

Login with GitHub to post a comment