?
avatar brianteeman
brianteeman
23 Feb 2020

I am not sure what the logic was for moving the filter before the search in the toolbar - I can't see any benefit. But it has an unfortunate side effect on pages that do not have a filter as it leaves the clear button just "floating around"

Also as I have said elsewhere that to me it is crazy having a layout override in one of the core templates.

Before

image

After

image

avatar brianteeman brianteeman - open - 23 Feb 2020
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 23 Feb 2020
avatar chmst
chmst - comment - 23 Feb 2020

The logic was: If I were blind, then I would like to know which input is in the search field before I klick the button clear.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28045.
avatar richard67
richard67 - comment - 23 Feb 2020

@brianteeman Does #28046 fix this issue?

avatar brianteeman
brianteeman - comment - 23 Feb 2020

@chmst which is why I was querying the change

avatar brianteeman brianteeman - change - 23 Feb 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-02-23 20:54:36
Closed_By brianteeman
avatar brianteeman brianteeman - close - 23 Feb 2020
avatar astridx
astridx - comment - 23 Feb 2020

@chmst The logic was: If I were blind, then I would like to know which input is in the search field before I klick the button clear.

I did not know this. But in this case we should not create an overwrite for Autum Template. In this case we should correct the layout https://github.com/joomla/joomla-cms/blob/4.0-dev/layouts/joomla/searchtools/default/bar.php, right?

Add a Comment

Login with GitHub to post a comment