[#28048] - [4.0] Enable Bootstrap's rounded styling in Atum
- Fixed in Code Base
- 29 Feb 2020
- Medium
- Build: 4.0-dev
- # 28048
- Diff
- SharkyKZ:j4/scss/bootstrap-rounded
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28042.
Summary of Changes
Since Atum practically switched to rounded styling, we should use existing Bootstrap's styles instead of manually adding border radius everywhere.
Testing Instructions
Inspect forms with button groups and input groups.
Expected result
OK styling.
Actual result
Border radius added where not needed:
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Layout |
For now yes. Last button should actually have border radius on the right. But Create button is not last, there are some hidden buttons which are displayed with JS.
| Labels |
Added:
?
|
||
| Category | Administration Templates (admin) Layout | ⇒ | Modules Administration Templates (admin) Layout |
Any specific page we can check with before/after ?
Mostly pages containing forms.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28048.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28048.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28048.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28048.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-29 08:23:55 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Found an issue in RTL for the search button
Looking into it.
is it expected that now none of the corners are rounded