[#28024] - [4.0] Merge core and com_media builds
- Fixed in Code Base
- 27 Feb 2020
- Medium
- Build: 4.0-dev
- # 28024
- Diff
- C-Lodder:merge-config
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
com_media has it's own package.json and build scripts. This PR merges them into core. They're now in a single location without any version mismatches.
Some of the dependencies needs to be bumped up
Testing Instructions
- Run
npm iand ensure there are no errors - Look at the Media Manager in the backend. Ensure there are no console errors and the page displays properly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change JavaScript |
26% building 135/136 modules 1 active ...joomla-cms\node_modules\sass-loader\lib\loader.js!C:\htdocs\joomla-cms\administrator\components\com_media\resources\styles\mediamanager.scss (node:50588) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
Did not get this message before
Seems to work ok though as its just a warning
@brianteeman dependencies need updating.
I ran npm update and then npm i again - same issue
or did I misunderstand
No sorry. I mean the dependencies need a proper update in the package.json. I've updated the bare minimum to get this merge working.
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Administration com_media NPM Change JavaScript | ⇒ | Administration com_media NPM Change JavaScript Repository |
You added Terser mate. https://github.com/joomla/joomla-cms/pull/28024/files#diff-11e9f7f953edc64ba14b0cc350ae7b9dL73 we were using the built in webpack uglify to minimize before your change
@wilsonge I know I added it. Was just specifying that I've removed it completely. Wepack minifies files differently now. It doesn't use Uglify. The script is now using webpack 4, not 3
Please just run the two tasks:
$ npm run dev:com_media
$ npm run build:com_media
and you'll see the difference in the generated files.
FYI this also fixes the ability to run npm i on Node 13.x
With the current separation, node-sass 4.12.x won't work on NodeJS 12.x
C-Lodder#7 merge this and we're good to go i think. Still not quite happy with the quality of the builds (i think babel-loader is minifying each file??) but the webpack itself is/isn't minified correctly in dev/prod builds. But that part can be improved later
Will merge once you've confirmed you've tested both build scripts
I have tested this item
Media loads OK, no console error.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28024.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-27 09:29:35 |
| Closed_By | ⇒ | HLeithner |
Thanks
@wilsonge this is a good starting point, merge it