? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
22 Feb 2020

As requested this PR adds a deprecation note for the ability to email an article which is removed in j4

avatar brianteeman brianteeman - open - 22 Feb 2020
avatar brianteeman brianteeman - change - 22 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2020
Category Front End com_content
avatar jwaisner
jwaisner - comment - 22 Feb 2020

@brianteeman Please provide test instructions for the PR.

avatar brianteeman
brianteeman - comment - 22 Feb 2020

If you read the pull request you will see there are no test instructions possible. You either understand the issue and can confirm it is correct or you don't. Its not essential to understand every issue. I certainly don't.

avatar jwaisner
jwaisner - comment - 23 Feb 2020

@brianteeman are you saying that this is a code review? or are you saying because I do not understand 1 sentence that provides no useful information that I should not attempt to understand?

avatar mbabker
mbabker - comment - 23 Feb 2020

It is a review only as there is nothing to test (except maybe downloading the modified file and ensuring no parse error gets introduced, but that should be picked up by CI systems and not reliant on a human to validate).

avatar jwaisner
jwaisner - comment - 23 Feb 2020

@mbabker Thank you for the clarification.

@brianteeman Please update notes to indicate code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28023.

avatar zero-24
zero-24 - comment - 24 Feb 2020

Merging thanks ?

avatar zero-24 zero-24 - change - 24 Feb 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-24 06:47:00
Closed_By zero-24
Labels Added: ? ?
avatar zero-24 zero-24 - close - 24 Feb 2020
avatar zero-24 zero-24 - merge - 24 Feb 2020

Add a Comment

Login with GitHub to post a comment