Feeling Lucky
?
[#27997] - With latest version of Application/Console Package from the Framework breaks CMS Console
- Closed
- 4 Mar 2020
- Urgent
- Build: 4.0-dev
- # 27997
Steps to reproduce the issue
Update the framework to latest application + console versions. All our console code breaks. This is related to how much symfony code we want to reproduce (i.e. the introduction of the application interface causing us to change how things work) and how the input class is used by the console
Fall out of #26820
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
jwaisner
- | Priority | Medium | ⇒ | Urgent |
| Status | New | ⇒ | Confirmed |
| Build | staging | ⇒ | 4.0-dev |
| Labels |
Removed:
?
|
||
| Labels |
Added:
?
|
||
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-04 07:34:42 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Removed:
?
|
||
You should be mostly OK on Console, joomla-framework/console@7032ec0...master is the diff from where the lock file says things are at now (the big change is the app handles uncaught Throwables with output instead of relying on an event listener to do it).
Application shouldn't be an issue on its own, it's going to introduce deprecations galore though because of deprecating the Input access as a property. joomla-framework/application@3d549e0...2.0-dev for the diff.
Combined, with the CMS environment's tight coupling to
Factory::getApplication()->input, that's where you start running into problems. Even this shouldn't prevent upgrading the Console package to current version, it's already unaware of theJoomla\Input\Inputclass anyway and as long asJoomla\Application\AbstractApplicationis at a version where it is input aware then nothing will be terribly broken.Because of this issue, OAuth1 and OAuth2 shouldn't be updated because they were modified to use the interfaces, see joomla-framework/oauth1@36da2b8...2.0-dev and joomla-framework/oauth2@98ff498...2.0-dev
From #27996 the only other questionable update is the Event package if
Joomla\Event\DelegatingDispatcheris in use anywhere (which, it shouldn't be). Everything else should be safe per SemVer and defined version constraints.