? ? Pending

User tests: Successful: Unsuccessful:

avatar twister65
twister65
20 Feb 2020

Pull Request for Issue # .

Summary of Changes

composer update --no-dev
This will update all Composer files to the latest versions as allowed in the composer.json file, except for the application, oauth1, oauth2, and console package.
This includes the Joomla! Framework packages !

Testing Instructions

Get a working installation from the source:

  • Clone the repository:
    git clone git@github.com:joomla/joomla-cms.git

  • Go to the joomla-cms folder:
    cd joomla-cms

  • Go to the 4.0-dev branch:
    git checkout 4.0-dev

  • Install all the needed composer packages:
    composer install

  • Install all the needed npm packages:
    npm install

Expected result

Actual result

Documentation Changes Required

avatar twister65 twister65 - open - 20 Feb 2020
avatar twister65 twister65 - change - 20 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Feb 2020
Category External Library Composer Change
avatar wilsonge
wilsonge - comment - 20 Feb 2020

I suspect this is going to break the Joomla console package. similar to how my version of this a while back did? #26820

We can probably selectively update other parts whilst I try and get a plan around the console package though

avatar twister65 twister65 - change - 21 Feb 2020
Labels Added: ? ?
avatar twister65 twister65 - change - 21 Feb 2020
The description was changed
avatar twister65 twister65 - edited - 21 Feb 2020
avatar twister65
twister65 - comment - 21 Feb 2020

@wilsonge , I removed the update for the console package.

avatar mbabker
mbabker - comment - 21 Feb 2020

See #27997 - Everything but the application and two OAuth packages are safe to update.

(Also, if you take out an update by manually editing the composer.lock, you need to run composer update --lock otherwise you are going to cause everyone to get warnings about the lock file hash being incorrect)

avatar twister65
twister65 - comment - 22 Feb 2020

@mbabker , if we update the console package, we still get this error:
console_error
I suggest not updating the joomla console package until @wilsonge finds a solution. This will be the subject of another PR.

avatar twister65 twister65 - change - 22 Feb 2020
The description was changed
avatar twister65 twister65 - edited - 22 Feb 2020
avatar mbabker
mbabker - comment - 22 Feb 2020

Bah, forgot that change.

Either way, you’re still introducing the Composer lock file hash error as the content-hash property isn’t updated here.

avatar twister65
twister65 - comment - 22 Feb 2020

@mbabker , when I run composer update --lock, the composer.lock file is always the same. I may have forgotten something.

avatar mbabker
mbabker - comment - 22 Feb 2020

Something is definitely wrong though because it should be impossible to have run composer update and not change the hash, yet if you look at the diff for this PR the hash is unchanged. That’s a red flag.

avatar twister65
twister65 - comment - 23 Feb 2020

This will update all Composer files to the latest versions as allowed in the composer.json file, except for the application, oauth1, oauth2, and console package.

composer

avatar twister65 twister65 - change - 23 Feb 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-02-23 17:16:47
Closed_By twister65
avatar twister65 twister65 - close - 23 Feb 2020

Add a Comment

Login with GitHub to post a comment