The linked issue at the top of the description is wrong. It is #24599 , but it should be #24559 .

Thanks fixed it

@rdeutz Not really, I still see ‘Pull Request for Issue #24599 .‘.

It's like cs fixes, it always takes two or more attempts to fix a trailing space :-)

Call to undefined method Joomla\CMS\MVC\Model\BaseModel::addIncludePath() 

Call stack
--
# | Function | Location
1 | () | JROOT\libraries\src\MVC\Controller\BaseController.php:186
2 | Joomla\CMS\MVC\Controller\BaseController::addModelPath() | JROOT\libraries\src\MVC\Controller\BaseController.php:460
3 | Joomla\CMS\MVC\Controller\BaseController->__construct() | JROOT\libraries\src\MVC\Factory\MVCFactory.php:77
4 | Joomla\CMS\MVC\Factory\MVCFactory->createController() | JROOT\libraries\src\Dispatcher\ComponentDispatcher.php:172
5 | Joomla\CMS\Dispatcher\ComponentDispatcher->getController() | JROOT\libraries\src\Dispatcher\ComponentDispatcher.php:145
6 | Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() | JROOT\libraries\src\Component\ComponentHelper.php:384
7 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT\libraries\src\Application\AdministratorApplication.php:115
8 | Joomla\CMS\Application\AdministratorApplication->dispatch() | JROOT\libraries\src\Application\AdministratorApplication.php:158
9 | Joomla\CMS\Application\AdministratorApplication->doExecute() | JROOT\libraries\src\Application\CMSApplication.php:230
10 | Joomla\CMS\Application\CMSApplication->execute() | JROOT\administrator\includes\app.php:63
11 | require_once() | JROOT\administrator\index.php:36

Last commit reintroduces the original issue.

This works but if we go this way the method should stay in LeagcyModelLoaderTrait (according to #24559).

@rdeutz Can you clarify in your testing instructions what components are affected by the change? I want to ensure that this is tested properly.

I have tested this with differenc components: com_cache, com_users, com_content and looks good.
But recommend more tests, especially with 3rd party components

@rdeutz Can you please resolve conflicts?

LeagcyModelLoaderTrait just realised this has a typo in xD

Confirmed with the weblinks module that this fixes the issue. Thankyou!

Wasn't this method supposed to stay in the trait?

Ideal world yes. But because of php internals it doesn’t work. See the original issue

It works either way. The fix was moving caching to class property. PR for moving back the method #28322.