? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
18 Feb 2020

Summary of Changes

Moves subform filtering logic from base FormField to SubformField and fixes subform filtering.

Testing Instructions

Edit System - Redirect plugin.
In Exclude URLs form add some rows.
In Term fields enter HTML content, e.g. <script>alert(1);</script>.
Save the plugin and inspect the field content.

Expected result

HTML stripped out, e.g. alert(1); remains.

Actual result

HTML not stripped out.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 18 Feb 2020
avatar SharkyKZ SharkyKZ - change - 18 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Feb 2020
Category Libraries
avatar astridx
astridx - comment - 23 Feb 2020

I have tested this Patch successful.

  1. git fetch origin pull/27980/head:j4/form/subform-filter
  2. git checkout j4/form/subform-filter
  3. No new install or npm ci is needed.
  4. I edited System - Redirect plugin like suggested for testing and I created a Custom Field of type subfield.
  5. In both cases HTML was not stripped out before applying the path. But it was stripped out after applying the path.
    Plugins  System   Redirect   admin   Administration(1)
    Articles  Edit   admin   Administration(2)

I tested with the current ‎4.0.0-beta1-dev on Ubuntu with PHP 7.2 and MySQL 5.7.

avatar astridx
astridx - comment - 23 Feb 2020

I have tested this item successfully on 5884f1e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27980.

avatar astridx astridx - test_item - 23 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 23 Feb 2020

I have tested this item successfully on 5884f1e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27980.

avatar Quy Quy - test_item - 23 Feb 2020 - Tested successfully
avatar Quy Quy - change - 23 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 23 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27980.

avatar HLeithner HLeithner - close - 23 Feb 2020
avatar HLeithner HLeithner - merge - 23 Feb 2020
avatar HLeithner HLeithner - change - 23 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-23 18:45:07
Closed_By HLeithner
Labels Added: ?
avatar HLeithner
HLeithner - comment - 23 Feb 2020

Thanks

Add a Comment

Login with GitHub to post a comment