[#27979] - [4.0] Fix Warning in repeatable field
- Closed
- 25 Feb 2020
- Medium
- Build: 4.0-dev
- # 27979
- Diff
- chmst:field-required-in-repeatable
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
A repeatable field without content causes a warning in an article.
Testing Instructions
Make a custom field of type repeatable and save it without adding a field.
Then open an article.
Expected result
The article is displayed
Actual result
Warning: Invalid argument supplied for foreach() in plugins\fields\repeatable\repeatable.php on line 89
Documentation Changes Required
idk
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||
Looks better. Just to check with this change do we get an error if the field is set as required in XML?
It makes no difference. With this PR there is no warning, that's all.
But it is possible to save a repeatable field (the container) with required=false
and no field in it.
This results in fields which looks like this:
So I wanted to make sure that at least one input field must be added to a repeatable.
But could be another issue / PR.
I have tested this item
In generell, don't know about repeatable fields yet :-)
But confirm Actual Result. After Patch: Warning has gone.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27979.
I am not able to reproduce the warning before the PR.
Could you save a repeatable field without a field?
Yes
Will try to load an image.
I tested with the latest development branch.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-25 19:25:20 |
| Closed_By | ⇒ | chmst |
This should be optional instead. On line 89 we should allow the field to be empty unless the required attribute is set to true