This forces com media to be built using npm ci

@N6REJ What Brian means is that npm ci is only available in npm version 6 or later but not yet in version 5, so you force peopel to have npm version 6 or later with this change.

No thats not what I mean. I meant exactly what I said

@richard67 It was added in npm 5.7.0 and the package.json dictates the user should be using this version: https://github.com/joomla/joomla-cms/blob/4.0-dev/package.json#L12

There's nothing wrong with this change, but you'll just need to make sure that dependency updates are done via npm i rather than npm ci, else the package-lock.json won't be updated.

Using ci will improve build times both locally and in the CI environment.

@C-Lodder I see ... thanks.

P.S.: And sorry @brianteeman .

There's nothing wrong with this change, but you'll just need to make sure that dependency updates are done via npm i rather than npm ci, else the package-lock.json won't be updated.

@brianteeman @C-Lodder Do you know if we have some developer docs which describe how to rebuild com_media and which would have to be updated with this change? If we don't have, do you think we should create some?

@richard67 the com_media build scripts should be merged with the cores ones. There's no reason to have them separate

@richard67 the com_media build scripts should be merged with the cores ones. There's no reason to have them separate

@wilsonge Is this already on someone's task list? I don't think I am the right one to reorganise our build scripts ... am not deep enough into that.

I have tested this item ✅ successfully on 3ff969c

Hint for other testers: Without the PR, file administrator/components/com_media/package-lock.json has not been re-created because there haven't been any changes in this file. So I have added an empty line to have a different checksum. Then I could reproduce that without this PR, the file is recreated, and with this PR it isn't.

I have tested this item ✅ successfully on 3ff969c

RTC

@N6REJ Can you commit against this please? #28024

or I can do it myself, up to you.

how?

@N6REJ Similar to making a PR for the CMS: Compare your branch for this PR with the target branch, but this is this time not the cms 4.0-dev branch but @C-Lodder 's branch for his PR. Then you can make PR.

To make it easier for you, here the link to the comparison of both branches: C-Lodder/joomla-cms@merge-config...N6REJ:npm.

Click the above link, check that it shows only the same changes as you do here with your PR and then use the green button to make a pull request. This will then make a PR in @C-Lodder 's repo. He can merge it and you can close this one here when you and him agree that his one will be used.

@C-Lodder @richard67 well, I did that but there is a conflict as he's completely changed the way it functions.

I guess there is no purpose in having mine at this point. Please advise.

@N6REJ I've just realised that npm ci is no longer required as it's doesn't cd to the com_media directory anymore. Users can manually run npm ci from their terminal iof they want to.

This PR can be closed.